From 234acdfdc873eb59448f7df447f7d114bb4b085c Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Mon, 1 Jul 2013 09:51:42 +0000 Subject: [PATCH] llvm-symbolizer: Recognize a drive letter on win32. Then "REQUIRES: shell" can be removed. FIXME: Could we use llvm::sys::Path here? llvm-svn: 185322 --- llvm/test/DebugInfo/llvm-symbolizer.test | 2 -- llvm/tools/llvm-symbolizer/LLVMSymbolize.cpp | 5 +++++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/llvm/test/DebugInfo/llvm-symbolizer.test b/llvm/test/DebugInfo/llvm-symbolizer.test index 11ba66428371..4dc369948fde 100644 --- a/llvm/test/DebugInfo/llvm-symbolizer.test +++ b/llvm/test/DebugInfo/llvm-symbolizer.test @@ -10,8 +10,6 @@ RUN: echo "%p/Inputs/macho-universal:x86_64 0x100000f05" >> %t.input RUN: llvm-symbolizer --functions --inlining --demangle=false \ RUN: --default-arch=i386 < %t.input | FileCheck %s -REQUIRES: shell - CHECK: main CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:16 diff --git a/llvm/tools/llvm-symbolizer/LLVMSymbolize.cpp b/llvm/tools/llvm-symbolizer/LLVMSymbolize.cpp index 57f34c247291..1945d689dee4 100644 --- a/llvm/tools/llvm-symbolizer/LLVMSymbolize.cpp +++ b/llvm/tools/llvm-symbolizer/LLVMSymbolize.cpp @@ -279,6 +279,11 @@ LLVMSymbolizer::getOrCreateModuleInfo(const std::string &ModuleName) { std::string BinaryName = ModuleName; std::string ArchName = Opts.DefaultArch; size_t ColonPos = ModuleName.find(':'); +#if defined(_WIN32) + // Recognize a drive letter on win32. + if (ColonPos == 1 && isalpha(ModuleName[0])) + ColonPos = ModuleName.find(':', 2); +#endif if (ColonPos != std::string::npos) { BinaryName = ModuleName.substr(0, ColonPos); ArchName = ModuleName.substr(ColonPos + 1);