03ff2596cb
Refactoring. Remove Owned method from Sema.
...
llvm-svn: 209812
2014-05-29 14:05:12 +00:00
01a7598561
Refactoring. Remove release and take methods from ActionResult. Rename takeAs to getAs.
...
llvm-svn: 209800
2014-05-29 10:55:11 +00:00
2afa8780d6
Consolidate some note diagnostics
...
These note diags have the same message and can be unified further but for now
let's just bring them together.
Incidental change: Display a source range in the final attr diagnostic.
llvm-svn: 209728
2014-05-28 12:20:14 +00:00
c3ec149bb2
[C++11] Use 'nullptr'. Sema edition.
...
llvm-svn: 209613
2014-05-26 06:22:03 +00:00
3a01af0805
PR19352 - getLocation() points to the wrong position for FriendDecls
...
llvm-svn: 209511
2014-05-23 12:48:27 +00:00
885ea4253d
DeclVisitor is not used here.
...
llvm-svn: 209285
2014-05-21 09:02:49 +00:00
065da7c53a
Fixed spelling.
...
llvm-svn: 209224
2014-05-20 18:23:05 +00:00
4284c6e7a4
Consolidate single void paramter checking
...
Also correct argument/parameter terminology.
No change in functionality.
llvm-svn: 208498
2014-05-11 16:05:55 +00:00
04e2e665cb
Don't emit -Wnon-virtual-dtor on final classes, since it's not a problem there.
...
The base class is the culprit/risk here - a sealed/final derived class
with virtual functions and a non-virtual dtor can't accidentally be
polymorphically destroyed (if the base class's dtor is protected - which
also suppresses this warning).
llvm-svn: 208449
2014-05-09 22:02:28 +00:00
a030cd0558
StringRefize and take out an old FIXME
...
llvm-svn: 207962
2014-05-05 12:38:48 +00:00
d78f92fbb2
Rewrite NRVO determination. Track NRVO candidates on the parser Scope and apply the NRVO candidate flag to all possible NRVO candidates here, and remove the flags in computeNRVO or upon template instantiation. A variable now has NRVO applied if and only if every return statement in that scope returns that variable. This is nearly optimal.
...
Performs NRVO roughly 7% more often in a bootstrap build of clang. Patch co-authored by Richard Smith.
llvm-svn: 207890
2014-05-03 00:41:18 +00:00
b6d4e8cd4e
Handle -fdelayed-template-parsing of out-of-line definitions of
...
class template member classes (PR19613)
Also improve this code in general by implementing suggestions
from Richard.
Differential Revision: http://reviews.llvm.org/D3555?id=9020
llvm-svn: 207822
2014-05-02 02:01:07 +00:00
09d5b3a928
Make typo-correction of inheriting constructors work a bit better. Limit
...
correction to direct base class members, and recover properly after we apply
such a correction.
llvm-svn: 207731
2014-05-01 00:35:04 +00:00
d94f2f16bd
When typo-correcting a member using declaration, don't exclude member templates.
...
llvm-svn: 207681
2014-04-30 18:15:00 +00:00
21866c3267
When typo-correcting a member using-declaration, only consider members of base classes.
...
llvm-svn: 207680
2014-04-30 18:03:21 +00:00
30a615dca8
Fix crash if typo correction corrects a member using-declaration to a
...
non-member declaration. Patch by Dinesh Dwivedi!
llvm-svn: 207677
2014-04-30 17:40:35 +00:00
2255f2ce90
Initial implementation of -modules-earch-all option, for searching for symbols in non-imported modules.
...
llvm-svn: 206977
2014-04-23 12:57:01 +00:00
06ffb45ce4
PR18746: If a constexpr function has a dependent return type and no return
...
statements, don't diagnose; the return type might end up being 'void'.
Patch by Rahul Jain! Tiny tweaks by me.
llvm-svn: 206929
2014-04-22 23:14:23 +00:00
cd45dbc5f2
When a module completes the definition of a class template specialization imported from another module, emit an update record, rather than using the broken decl rewriting mechanism. If multiple modules do this, merge the definitions together, much as we would if they were separate declarations.
...
llvm-svn: 206680
2014-04-19 03:48:30 +00:00
4b55a9c841
Refactor all the checking for missing 'template<>'s when a declaration has a
...
template-id after its scope specifier into a single place.
llvm-svn: 206442
2014-04-17 03:29:33 +00:00
82dce550c8
PR19415: Converting 'constexpr' to 'const' in a non-static data member can fail
...
if the member is already 'const'. Don't assert in that case.
llvm-svn: 206205
2014-04-14 21:00:40 +00:00
83e78f5c3c
Fix handling of redeclaration lookup for using declarations, where the prior
...
declaration is not visible. Previously we didn't find hidden friend names in
this redeclaration lookup, because we forgot to treat it as a redeclaration
lookup. Conversely, we did find some local extern names, but those don't
actually conflict with a namespace-scope using declaration, because the only
conflicts we can get are scope conflicts, not conflicts due to the entities
being members of the same namespace.
llvm-svn: 206011
2014-04-11 01:03:38 +00:00
7ad0b88396
If a using-declaration names a class member, but appears outside a class, try
...
to suggest a different syntax to get the same effect.
llvm-svn: 205467
2014-04-02 21:44:35 +00:00
ee4f4025c3
Sema: Implement DR317
...
Summary:
Declaring a function as inline after it has been defined is in violation
of [dcl.fct.spec]p4. The program would get a strong definition instead
of getting a function with linkonce_odr linkage.
Reviewers: rsmith
CC: cfe-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3220
llvm-svn: 205129
2014-03-30 06:44:54 +00:00
5604a27788
Don't emit exit-time destructor warnings for trivial explicitly defaulted dtors
...
This commit also adds an additional test case for the global destructor warning.
Reviewed in http://llvm-reviews.chandlerc.com/D3205
llvm-svn: 204954
2014-03-27 20:23:36 +00:00
c511f43b67
-Wglobal-constructors: Don't warn on trivial defaulted dtors
...
Fixes PR19253.
llvm-svn: 204825
2014-03-26 15:58:20 +00:00
564417a071
When the exception specification for a function in an imported PCH or module is
...
resolved, emit an update record.
llvm-svn: 204403
2014-03-20 21:47:22 +00:00
18d85aed39
Replacing the exclusive_lock_function, shared_lock_function and unlock_function attributes with the acquire_capability and release_capability attributes. The old spellings will continue to work, but the underlying semantic attributes have been replaced.
...
Downgraded the capability diagnostics from error to warning to match the desired behavior, and updated the existing test cases.
llvm-svn: 204350
2014-03-20 16:02:49 +00:00
b088fbee3f
[C++11] Replacing FunctionProtoType iterators exception_begin() and exception_end() with iterator_range exceptions(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 204046
2014-03-17 15:38:09 +00:00
c7e4e219b5
[C++11] Replacing CompoundStmt iterators body_begin() and body_end() with iterator_range body(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 204040
2014-03-17 14:19:37 +00:00
535bbcccb1
[C++11] Replacing DeclStmt iterators decl_begin() and decl_end() with iterator_range decls(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203947
2014-03-14 17:01:24 +00:00
0ad78303de
[C++11] Replacing CXXRecordDecl iterators init_begin() and init_end() with iterator_range inits(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203819
2014-03-13 17:34:31 +00:00
2a4bd6d189
[C++11] Replacing CXXRecordDecl iterators ctor_begin() and ctor_end() with iterator_range ctors(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203814
2014-03-13 16:51:27 +00:00
2b124d1a5d
[C++11] Replacing CXXRecordDecl iterators method_begin() and method_end() with iterator_range methods(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203812
2014-03-13 16:36:16 +00:00
445a939db8
[C++11] Replacing CXXRecordDecl iterators vbases_begin() and vbases_end() with iterator_range vbases(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203808
2014-03-13 16:15:17 +00:00
574705ed7f
[C++11] Replacing CXXRecordDecl iterators bases_begin() and bases_end() with iterator_range bases(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203803
2014-03-13 15:41:46 +00:00
5b5d21ea1a
Only allow streaming exactly type 'bool' to a DiagnosticBuilder, not anything
...
that implicitly converts to 'bool' (such as pointers, and the first operand of
?:). Clean up issues found by this. Patch by Stephan Tolksdorf!
llvm-svn: 203735
2014-03-12 23:36:42 +00:00
b97112e4bd
[C++11] Replacing Decl iterators attr_begin() and attr_end() with iterator_range attrs(). Updating all of the usages of the iterators with range-based for loops.
...
This is a reapplication of r203236 with modifications to the definition of attrs() and following the new style guidelines on auto usage.
llvm-svn: 203362
2014-03-08 22:19:01 +00:00
e8a8baef44
[C++11] Replacing RecordDecl iterators field_begin() and field_end() with iterator_range fields(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203355
2014-03-08 20:12:42 +00:00
629afaefe0
[C++11] Replacing DeclBase iterators decls_begin() and decls_end() with iterator_range decls(). The same is true for the noload versions of these APIs. Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203278
2014-03-07 19:56:05 +00:00
29c9460d3e
Renaming the chains() ranged iterator to chain() per suggestion by Richard Smith.
...
llvm-svn: 203262
2014-03-07 18:36:15 +00:00
1391608234
[C++11] Replacing IndirectFieldDecl iterators chain_begin() and chain_end() with iterator_range chains(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203261
2014-03-07 18:11:58 +00:00
f6bf62e2d0
[C++11] Replacing FunctionDecl iterators param_begin() and param_end() with iterator_range params(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203248
2014-03-07 15:12:56 +00:00
7dce1a840c
Fully reverting r203236 -- it seems the only bots that are happy are the MSVC bots.
...
llvm-svn: 203237
2014-03-07 13:13:38 +00:00
690829696c
[C++11] Replacing iterators attr_begin() and attr_end() with iterator_range attrs(). Updating all of the usages of the iterators with range-based for loops.
...
llvm-svn: 203236
2014-03-07 12:50:00 +00:00
86c9390673
[C++11] Replacing iterators redecls_begin() and redecls_end() with iterator_range redecls(). Updating all of the usages of the iterators with range-based for loops, which allows the begin/end forms to be removed entirely.
...
llvm-svn: 203179
2014-03-06 23:45:36 +00:00
a798a9db93
Switch all uses of LLVM_OVERRIDE to just use 'override' directly.
...
llvm-svn: 202625
2014-03-02 09:32:10 +00:00
95833f33bd
Diagnose attempts to apply ms_struct to records with base classes
...
or virtual functions, but permit that error to be downgraded to
a warning (with -Wno-error=incompatible-ms-struct), and officially
support this kind of dual, ABI-mixing layout.
The basic problem here is that projects which use ms_struct are often
not very circumspect about what types they annotate; for example,
some projects enable the pragma in a prefix header and then only
selectively disable it around system header inclusions. They may
only care about binary compatibility with MSVC for a subset of
those structs, but that doesn't mean they have no binary
compatibility concerns at all for the rest; thus we are essentially
forced into supporting this hybrid ABI. But it's reasonable for
us to at least point out the places where we're not making
any guarantees.
The original diagnostic was for dynamic classes, i.e. those with
virtual functions or virtual bases; I've extended it to include
all classes with bases, because we are not actually making any
attempt to duplicate MSVC's base subobject layout in ms_struct
(and it is indeed quite different from Itanium, even for
non-virtual bases).
rdar://16178895
llvm-svn: 202427
2014-02-27 20:30:49 +00:00
c535072d0d
argument -> parameter terminology fixes for FunctionTypeInfo
...
This is a continuation of r199686.
llvm-svn: 202307
2014-02-26 22:27:52 +00:00
3d79154aec
[Win32 ABI] Defer operator delete checks until vtable is marked used
...
We were previously checking at every destructor declaration, but that was a bit
excessive. Since the deleting destructor is emitted with the vtable, do the
check when the vtable is marked used.
Differential Revision: http://llvm-reviews.chandlerc.com/D2851
llvm-svn: 202046
2014-02-24 15:58:24 +00:00
Nikola Smiljanic