Commit Graph

4 Commits

Author SHA1 Message Date
Yan Zhang f2876e3385 update readability-identifier-naming-objc test to use interface ivar. Implementation ivars are not supported in 32-bits OS.
Reviewers: alexfh, chandlerc

Subscribers: klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D45936

llvm-svn: 330562
2018-04-23 01:05:02 +00:00
Yan Zhang 004b6c6842 update test to use ivar in implementation instead of class extension
Summary: using ivar in class extension is not supported in 32-bit architecture of MacOS.

Reviewers: alexfh, hokein

Reviewed By: alexfh

Subscribers: klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D45912

llvm-svn: 330559
2018-04-23 00:15:15 +00:00
Chandler Carruth e6bfb2c71d Revert r330492: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'
This commit has been breaking most bots for a day now. There is a fix
proposed in https://reviews.llvm.org/D45912 but when I applied that
I just got different errors. Reverting to get our bots back to green.

llvm-svn: 330528
2018-04-21 23:27:34 +00:00
Yan Zhang e3f50ecb3a [clang-tidy] add new check to find out objc ivars which do not have prefix '_'
Summary:
For code of ivar declaration:

   int barWithoutPrefix;

The fix will be:

   int _barWithoutPrefix;

Reviewers: benhamilton, hokein, alexfh, aaron.ballman, ilya-biryukov

Reviewed By: alexfh

Subscribers: Eugene.Zelenko, xazax.hun, klimek, mgorny, cfe-commits

Tags: #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D45392

llvm-svn: 330492
2018-04-20 23:18:09 +00:00