forked from OSchip/llvm-project
8fafb8d378
LLVM's use of DW_OP_bit_piece is incorrect and a based on a misunderstanding of the wording in the DWARF specification. The offset argument of DW_OP_bit_piece refers to the offset into the location that is on the top of the DWARF expression stack, and not an offset into the source variable. This has since also been clarified in the DWARF specification. This patch fixes all uses of DW_OP_bit_piece to emit the correct offset and simplifies the DwarfExpression class to semi-automaticaly emit empty DW_OP_pieces to adjust the offset of the source variable, thus simplifying the code using DwarfExpression. While this is an incompatible bugfix, in practice I don't expect this to be much of a problem since LLVM's old interpretation and the correct interpretation of DW_OP_bit_piece differ only when there are gaps in the fragmented locations of the described variables or if individual fragments are smaller than a byte. LLDB at least won't interpret locations with gaps in them because is has no way to present undefined bits in a variable, and there is a high probability that an old-form expression will be malformed when interpreted correctly, because the DW_OP_bit_piece offset will be outside of the location at the top of the stack. As a nice side-effect, this patch enables us to use a more efficient encoding for subregisters: In order to express a sub-register at a non-zero offset we now use a DW_OP_bit_piece instead of shifting the value into place manually. This patch also adds missing test coverage for code paths that weren't exercised before. <rdar://problem/29335809> Differential Revision: https://reviews.llvm.org/D27550 llvm-svn: 289266 |
||
|---|---|---|
| .. | ||
| ARMException.cpp | ||
| AddressPool.cpp | ||
| AddressPool.h | ||
| AsmPrinter.cpp | ||
| AsmPrinterDwarf.cpp | ||
| AsmPrinterHandler.h | ||
| AsmPrinterInlineAsm.cpp | ||
| ByteStreamer.h | ||
| CMakeLists.txt | ||
| CodeViewDebug.cpp | ||
| CodeViewDebug.h | ||
| DIE.cpp | ||
| DIEHash.cpp | ||
| DIEHash.h | ||
| DbgValueHistoryCalculator.cpp | ||
| DbgValueHistoryCalculator.h | ||
| DebugHandlerBase.cpp | ||
| DebugHandlerBase.h | ||
| DebugLocEntry.h | ||
| DebugLocStream.cpp | ||
| DebugLocStream.h | ||
| DwarfAccelTable.cpp | ||
| DwarfAccelTable.h | ||
| DwarfCFIException.cpp | ||
| DwarfCompileUnit.cpp | ||
| DwarfCompileUnit.h | ||
| DwarfDebug.cpp | ||
| DwarfDebug.h | ||
| DwarfException.h | ||
| DwarfExpression.cpp | ||
| DwarfExpression.h | ||
| DwarfFile.cpp | ||
| DwarfFile.h | ||
| DwarfStringPool.cpp | ||
| DwarfStringPool.h | ||
| DwarfUnit.cpp | ||
| DwarfUnit.h | ||
| EHStreamer.cpp | ||
| EHStreamer.h | ||
| ErlangGCPrinter.cpp | ||
| LLVMBuild.txt | ||
| OcamlGCPrinter.cpp | ||
| WinException.cpp | ||
| WinException.h | ||