[Support] Add comment to explain why we can't drop NDEBUG.

Discussed with: Benjamin Kramer. llvm-svn: 251210
2015-10-24 22:15:32 +00:00 · 2015-10-24 22:15:32 +00:00 · 05d980e48d
parent df1ec5561a
commit 05d980e48d
1 changed files with 5 additions and 0 deletions
--- a/llvm/include/llvm/Support/UnicodeCharRanges.h
+++ b/llvm/include/llvm/Support/UnicodeCharRanges.h
@ -51,6 +51,11 @@ public:
  /// the constructor, so it makes sense to create as few UnicodeCharSet
  /// instances per each array of ranges, as possible.
 #ifdef NDEBUG
+
+  // FIXME: This could use constexpr + static_assert. This way we
+  // may get rid of NDEBUG in this header. Unfortunately there are some
+  // problems to get this working with MSVC 2013. Change this when
+  // the support for MSVC 2013 is dropped.
  LLVM_CONSTEXPR UnicodeCharSet(CharRanges Ranges) : Ranges(Ranges) {}
 #else
  UnicodeCharSet(CharRanges Ranges) : Ranges(Ranges) {