OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

[x86] limit extractelement of setcc to pre-legalization 

A fuzzer found the crasher:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13700

The bug was introduced recently here:
rL355741

This is the quick fix. If we need to do this transform
later, then we'd have to extend/truncate the vector setcc
element type to the scalar setcc type (i8). 

llvm-svn: 356053
This commit is contained in:
Sanjay Patel 2019-03-13 14:49:52 +00:00
parent 9bfd140ddb
commit 0a251e4076
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Target/X86/X86ISelLowering.cpp
View File

@ -34349,7 +34349,7 @@ static SDValue scalarizeExtEltFP(SDNode *ExtElt, SelectionDAG &DAG) {
// Vector FP compares don't fit the pattern of FP math ops (propagate, not // Vector FP compares don't fit the pattern of FP math ops (propagate, not
// extract, the condition code), so deal with those as a special-case. // extract, the condition code), so deal with those as a special-case.
if (Vec.getOpcode() == ISD::SETCC) { if (Vec.getOpcode() == ISD::SETCC && VT == MVT::i1) {
EVT OpVT = Vec.getOperand(0).getValueType().getScalarType(); EVT OpVT = Vec.getOperand(0).getValueType().getScalarType();
if (OpVT != MVT::f32 && OpVT != MVT::f64) if (OpVT != MVT::f32 && OpVT != MVT::f64)
return SDValue(); return SDValue();

19
llvm/test/CodeGen/X86/extractelement-fp.ll
View File

@ -152,6 +152,25 @@ define i1 @fcmp_v4f64(<4 x double> %x, <4 x double> %y) nounwind {
ret i1 %r ret i1 %r
} }
; If we do the fcmp transform late, make sure we have the right types.
; https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13700
define void @extsetcc(<4 x float> %x) {
; CHECK-LABEL: extsetcc:
; CHECK: # %bb.0:
; CHECK-NEXT: vxorps %xmm1, %xmm1, %xmm1
; CHECK-NEXT: vcmpnleps %xmm0, %xmm1, %xmm0
; CHECK-NEXT: vextractps $0, %xmm0, %eax
; CHECK-NEXT: andl $1, %eax
; CHECK-NEXT: movb %al, (%rax)
; CHECK-NEXT: retq
%cmp = fcmp ult <4 x float> %x, zeroinitializer
%sext = sext <4 x i1> %cmp to <4 x i32>
%e = extractelement <4 x i1> %cmp, i1 0
store i1 %e, i1* undef
ret void
}
define float @select_fcmp_v4f32(<4 x float> %x, <4 x float> %y, <4 x float> %z, <4 x float> %w) nounwind { define float @select_fcmp_v4f32(<4 x float> %x, <4 x float> %y, <4 x float> %z, <4 x float> %w) nounwind {
; CHECK-LABEL: select_fcmp_v4f32: ; CHECK-LABEL: select_fcmp_v4f32:
; CHECK: # %bb.0: ; CHECK: # %bb.0: