OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

[ELF] Clarify --export-dynamic-symbol/--dynamic-list. NFC

This commit is contained in:
Fangrui Song 2021-09-16 17:13:08 -07:00
parent 26aff847d8
commit 1d08a19a38
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lld/ELF/Driver.cpp
View File

@ -1377,9 +1377,19 @@ static void readConfigs(opt::InputArgList &args) {
error(arg->getSpelling() + ": " + toString(pat.takeError())); error(arg->getSpelling() + ": " + toString(pat.takeError()));
} }
// When producing an executable, --dynamic-list specifies non-local defined // For -no-pie and -pie, --export-dynamic-symbol specifies defined symbols
// symbols which are required to be exported. When producing a shared object, // which should be exported. For -shared, references to matched non-local
// symbols not specified by --dynamic-list are non-preemptible. // STV_DEFAULT symbols are not bound to definitions within the shared object,
// even if other options express a symbolic intention: -Bsymbolic,
// -Bsymbolic-functions (if STT_FUNC), --dynamic-list.
for (auto *arg : args.filtered(OPT_export_dynamic_symbol))
config->dynamicList.push_back(
{arg->getValue(), /*isExternCpp=*/false,
/*hasWildcard=*/hasWildcard(arg->getValue())});
// --export-dynamic-symbol-list specifies a list of --export-dynamic-symbol
// patterns. --dynamic-list is --export-dynamic-symbol-list plus -Bsymbolic
// like semantics.
config->symbolic = config->symbolic =
config->bsymbolic == BsymbolicKind::All || args.hasArg(OPT_dynamic_list); config->bsymbolic == BsymbolicKind::All || args.hasArg(OPT_dynamic_list);
for (auto *arg : for (auto *arg :
@ -1387,14 +1397,6 @@ static void readConfigs(opt::InputArgList &args) {
if (Optional<MemoryBufferRef> buffer = readFile(arg->getValue())) if (Optional<MemoryBufferRef> buffer = readFile(arg->getValue()))
readDynamicList(*buffer); readDynamicList(*buffer);
// --export-dynamic-symbol specifies additional --dynamic-list symbols if any
// other option expresses a symbolic intention: -no-pie, -pie, -Bsymbolic,
// -Bsymbolic-functions (if STT_FUNC), --dynamic-list.
for (auto *arg : args.filtered(OPT_export_dynamic_symbol))
config->dynamicList.push_back(
{arg->getValue(), /*isExternCpp=*/false,
/*hasWildcard=*/hasWildcard(arg->getValue())});
for (auto *arg : args.filtered(OPT_version_script)) for (auto *arg : args.filtered(OPT_version_script))
if (Optional<std::string> path = searchScript(arg->getValue())) { if (Optional<std::string> path = searchScript(arg->getValue())) {
if (Optional<MemoryBufferRef> buffer = readFile(*path)) if (Optional<MemoryBufferRef> buffer = readFile(*path))