OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

Fix accidental use of CheckSVal instead of CheckLocation, and add a 

small test case to show we handle dereferences of undefined values.

llvm-svn: 85492
This commit is contained in:
Ted Kremenek 2009-10-29 05:33:39 +00:00
parent 98261735b4
commit 1dbdbcc04c
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/lib/Analysis/GRExprEngineInternalChecks.cpp
View File

@ -763,7 +763,7 @@ class VISIBILITY_HIDDEN CheckUndefDeref : public Checker {
public: public:
CheckUndefDeref() : BT(0) {} CheckUndefDeref() : BT(0) {}
ExplodedNode *CheckSVal(const Stmt *S, ExplodedNode *Pred, ExplodedNode *CheckLocation(const Stmt *S, ExplodedNode *Pred,
const GRState *state, SVal V, GRExprEngine &Eng); const GRState *state, SVal V, GRExprEngine &Eng);
static void *getTag() { static void *getTag() {
@ -772,7 +772,7 @@ public:
} }
}; };
ExplodedNode *CheckUndefDeref::CheckSVal(const Stmt *S, ExplodedNode *Pred, ExplodedNode *CheckUndefDeref::CheckLocation(const Stmt *S, ExplodedNode *Pred,
const GRState *state, SVal V, const GRState *state, SVal V,
GRExprEngine &Eng) { GRExprEngine &Eng) {
GRStmtNodeBuilder &Builder = Eng.getBuilder(); GRStmtNodeBuilder &Builder = Eng.getBuilder();

6
clang/test/Analysis/misc-ps.m
View File

@ -154,6 +154,12 @@ void handle_sizeof_void(unsigned flag) {
*p = 1; // no-warning *p = 1; // no-warning
} }
// check deference of undefined values
void check_deref_undef(void) {
int *p;
*p = 0xDEADBEEF; // expected-warning{{Dereference of undefined pointer value}}
}
// PR 3422 // PR 3422
void pr3422_helper(char *p); void pr3422_helper(char *p);
void pr3422() { void pr3422() {