From 2d6f4fec07292f1d2f77cbbf5188de3838a70b78 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 14 May 2020 12:27:26 -0700 Subject: [PATCH] [lldb/Test] Skip test using files to synchronize. Files written by the inferior are not captured by the reproducers and the inferior doesn't actually run during replay. --- lldb/test/API/commands/settings/TestSettings.py | 4 ++++ lldb/test/API/commands/settings/quoting/TestQuoting.py | 1 + 2 files changed, 5 insertions(+) diff --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py index 29360856a735..fc872f6240fe 100644 --- a/lldb/test/API/commands/settings/TestSettings.py +++ b/lldb/test/API/commands/settings/TestSettings.py @@ -203,10 +203,12 @@ class SettingsCommandTestCase(TestBase): substrs=["5ah"]) @skipIfDarwinEmbedded # debugserver on ios etc can't write files + @skipIfReproducer def test_run_args_and_env_vars(self): self.do_test_run_args_and_env_vars(use_launchsimple=False) @skipIfDarwinEmbedded # debugserver on ios etc can't write files + @skipIfReproducer def test_launchsimple_args_and_env_vars(self): self.do_test_run_args_and_env_vars(use_launchsimple=True) @@ -286,6 +288,7 @@ class SettingsCommandTestCase(TestBase): "Environment variable 'MY_ENV_VAR' successfully passed."]) @skipIfRemote # it doesn't make sense to send host env to remote target + @skipIfReproducer def test_pass_host_env_vars(self): """Test that the host env vars are passed to the launched process.""" self.build() @@ -382,6 +385,7 @@ class SettingsCommandTestCase(TestBase): "The host environment variable 'MY_HOST_ENV_VAR2' successfully passed."]) @skipIfDarwinEmbedded # debugserver on ios etc can't write files + @skipIfReproducer def test_set_error_output_path(self): """Test that setting target.error/output-path for the launched process works.""" self.build() diff --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py b/lldb/test/API/commands/settings/quoting/TestQuoting.py index d7581951a147..a415ea8ee247 100644 --- a/lldb/test/API/commands/settings/quoting/TestQuoting.py +++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py @@ -64,6 +64,7 @@ class SettingsCommandTestCase(TestBase): def test_bare_double(self): self.do_test_args('a\\"b', 'a"b\0') + @skipIfReproducer # Reproducers don't know about output.txt def do_test_args(self, args_in, args_out): """Test argument parsing. Run the program with args_in. The program dumps its arguments to stdout. Compare the stdout with args_out."""