OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

Fix a null pointer dereference error due to state caching in a loop involving 

sending a message to a nil receiver.

llvm-svn: 68686
This commit is contained in:
Ted Kremenek 2009-04-09 06:02:06 +00:00
parent cb5d3ced70
commit 2f3b0dbff4
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
clang/lib/Analysis/GRExprEngine.cpp
View File

@ -1704,10 +1704,8 @@ void GRExprEngine::VisitObjCMessageExprDispatchHelper(ObjCMessageExpr* ME,
N->markAsSink();
if (isFeasibleNotNull)
NilReceiverStructRetImplicit.insert(N);
else {
else
NilReceiverStructRetExplicit.insert(N);
return;
}
}
}
}
@ -1725,10 +1723,8 @@ void GRExprEngine::VisitObjCMessageExprDispatchHelper(ObjCMessageExpr* ME,
N->markAsSink();
if(isFeasibleNotNull)
NilReceiverLargerThanVoidPtrRetImplicit.insert(N);
else {
else
NilReceiverLargerThanVoidPtrRetExplicit.insert(N);
return;
}
}
}
else if (!isFeasibleNotNull) {
@ -1753,7 +1749,10 @@ void GRExprEngine::VisitObjCMessageExprDispatchHelper(ObjCMessageExpr* ME,
}
}
// We have handled the cases where the receiver is nil. The remainder
// of this method should assume that the receiver is not nil.
// of this method should assume that the receiver is not nil.
if (!StNotNull)
return;
state = StNotNull;
}