From 3bbd380a5b51db23e829f8ce6b948e7b9d451f15 Mon Sep 17 00:00:00 2001 From: Warren Ristow Date: Mon, 25 Jul 2022 10:24:43 -0700 Subject: [PATCH] [Reassociate][NFC] Use an appropriate dyn_cast for BinaryOperator In D129523, it was noted that there is are some questionable naked casts from Instruction to BinaryOperator, which could be addressed by doing a dyn_cast directly to BinaryOperator, avoiding the need for the later cast. This cleans up that casting. Reviewed By: nikic, spatel, RKSimon Differential Revision: https://reviews.llvm.org/D130448 --- llvm/lib/Transforms/Scalar/Reassociate.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/llvm/lib/Transforms/Scalar/Reassociate.cpp b/llvm/lib/Transforms/Scalar/Reassociate.cpp index 53575f55c6fb..cd2ce8ce336e 100644 --- a/llvm/lib/Transforms/Scalar/Reassociate.cpp +++ b/llvm/lib/Transforms/Scalar/Reassociate.cpp @@ -154,20 +154,20 @@ static bool hasFPAssociativeFlags(Instruction *I) { /// Return true if V is an instruction of the specified opcode and if it /// only has one use. static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode) { - auto *I = dyn_cast(V); - if (I && I->hasOneUse() && I->getOpcode() == Opcode) - if (!isa(I) || hasFPAssociativeFlags(I)) - return cast(I); + auto *BO = dyn_cast(V); + if (BO && BO->hasOneUse() && BO->getOpcode() == Opcode) + if (!isa(BO) || hasFPAssociativeFlags(BO)) + return BO; return nullptr; } static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode1, unsigned Opcode2) { - auto *I = dyn_cast(V); - if (I && I->hasOneUse() && - (I->getOpcode() == Opcode1 || I->getOpcode() == Opcode2)) - if (!isa(I) || hasFPAssociativeFlags(I)) - return cast(I); + auto *BO = dyn_cast(V); + if (BO && BO->hasOneUse() && + (BO->getOpcode() == Opcode1 || BO->getOpcode() == Opcode2)) + if (!isa(BO) || hasFPAssociativeFlags(BO)) + return BO; return nullptr; }