OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

tsan: use DCHECK_GT/LT instead of plain DCHECK (better diagnostics) 

llvm-svn: 157567
This commit is contained in:
Dmitry Vyukov 2012-05-28 07:45:35 +00:00
parent 2d4e3c140f
commit 3de9ca068f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
compiler-rt/lib/tsan/rtl/tsan_rtl.cc
View File

@ -443,8 +443,8 @@ void FuncEntry(ThreadState *thr, uptr pc) {
// Shadow stack maintenance can be replaced with // Shadow stack maintenance can be replaced with
// stack unwinding during trace switch (which presumably must be faster). // stack unwinding during trace switch (which presumably must be faster).
DCHECK(thr->shadow_stack_pos >= &thr->shadow_stack[0]); DCHECK_GE(thr->shadow_stack_pos, &thr->shadow_stack[0]);
DCHECK(thr->shadow_stack_pos < &thr->shadow_stack[kShadowStackSize]); DCHECK_LT(thr->shadow_stack_pos, &thr->shadow_stack[kShadowStackSize]);
thr->shadow_stack_pos[0] = pc; thr->shadow_stack_pos[0] = pc;
thr->shadow_stack_pos++; thr->shadow_stack_pos++;
} }
@ -456,8 +456,8 @@ void FuncExit(ThreadState *thr) {
thr->fast_state.IncrementEpoch(); thr->fast_state.IncrementEpoch();
TraceAddEvent(thr, thr->fast_state.epoch(), EventTypeFuncExit, 0); TraceAddEvent(thr, thr->fast_state.epoch(), EventTypeFuncExit, 0);
DCHECK(thr->shadow_stack_pos > &thr->shadow_stack[0]); DCHECK_GT(thr->shadow_stack_pos, &thr->shadow_stack[0]);
DCHECK(thr->shadow_stack_pos < &thr->shadow_stack[kShadowStackSize]); DCHECK_LT(thr->shadow_stack_pos, &thr->shadow_stack[kShadowStackSize]);
thr->shadow_stack_pos--; thr->shadow_stack_pos--;
} }