OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

Have DataLayout::isLegalInteger() accept uint64_t 

While not strictly necessary, since we don't support large integer
types, this avoids bugs due to silent truncation from uint64_t to a
32-bit unsigned (e.g. DL.isLegalInteger(DL.getTypeSizeInBits(Ty) )

This fixes PR26972.

Differential Revision: http://reviews.llvm.org/D18258

llvm-svn: 263850
This commit is contained in:
Michael Kuperstein 2016-03-18 23:19:29 +00:00
parent 86bc631793
commit 5abc2765fa
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/include/llvm/IR/DataLayout.h
View File

@ -236,14 +236,14 @@ public:
/// on any known one. This returns false if the integer width is not legal. /// on any known one. This returns false if the integer width is not legal.
/// ///
/// The width is specified in bits. /// The width is specified in bits.
bool isLegalInteger(unsigned Width) const { bool isLegalInteger(uint64_t Width) const {
for (unsigned LegalIntWidth : LegalIntWidths) for (unsigned LegalIntWidth : LegalIntWidths)
if (LegalIntWidth == Width) if (LegalIntWidth == Width)
return true; return true;
return false; return false;
} }
bool isIllegalInteger(unsigned Width) const { return !isLegalInteger(Width); } bool isIllegalInteger(uint64_t Width) const { return !isLegalInteger(Width); }
/// Returns true if the given alignment exceeds the natural stack alignment. /// Returns true if the given alignment exceeds the natural stack alignment.
bool exceedsNaturalStackAlignment(unsigned Align) const { bool exceedsNaturalStackAlignment(unsigned Align) const {

17
llvm/test/Transforms/SROA/pr26972.ll Normal file
View File

@ -0,0 +1,17 @@
; RUN: opt < %s -sroa -S | FileCheck %s
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-linux"
; Make sure we properly handle allocas where the allocated
; size overflows a uint32_t. This specific constant results in
; the size in bits being 32 after truncation to a 32-bit int.
; CHECK-LABEL: fn1
; CHECK-NEXT: ret void
define void @fn1() {
%a = alloca [1073741825 x i32], align 16
%t0 = bitcast [1073741825 x i32]* %a to i8*
call void @llvm.lifetime.end(i64 4294967300, i8* %t0)
ret void
}
declare void @llvm.lifetime.end(i64, i8* nocapture)