OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

Removing a TODO: can_catch is fundamentally different than search_above_dst. can_catch is looking for an unamiguous public base class of a specific type, but at any address. search_above_dst is looking for an unambiguous public base class of a specific type, *and* at a specific address. Additionally can_catch is run for all types. search_above_dst is only run on class types. So these are only superficially similar. Not similar enough for resuse, at least without making the code unreadable. 

llvm-svn: 149522
This commit is contained in:
Howard Hinnant 2012-02-01 18:52:35 +00:00
parent e273cb08c4
commit 69a10f466b
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libcxxabi/src/private_typeinfo.cpp
View File

@ -218,8 +218,6 @@ __pointer_to_member_type_info::display() const
// //
// catch (...) : adjustedPtr == & of the exception // catch (...) : adjustedPtr == & of the exception
// TODO: can_catch looks similar to search_above_dst. Reuse?
bool bool
__shim_type_info::can_catch(const __shim_type_info* thrown_type, __shim_type_info::can_catch(const __shim_type_info* thrown_type,
void*&) const void*&) const