OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

Remove logic for computing 'display hint'. 

llvm-svn: 64973
This commit is contained in:
Ted Kremenek 2009-02-18 22:59:04 +00:00
parent 6805ac6ab0
commit 75a96ed40a
1 changed files with 2 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
clang/lib/Analysis/CFRefCount.cpp
View File

@ -2597,27 +2597,8 @@ CFRefLeakReport::getEndPath(BugReporter& br, const ExplodedNode<GRState>* EndN){
assert (S); assert (S);
unsigned EndLine = SMgr.getInstantiationLineNumber(S->getLocStart()); unsigned EndLine = SMgr.getInstantiationLineNumber(S->getLocStart());
// Look in the *trimmed* graph at the immediate predecessor of EndN. Does
// it occur on the same line?
PathDiagnosticPiece::DisplayHint Hint = PathDiagnosticPiece::Above;
assert (!EndN->pred_empty()); // Not possible to have 0 predecessors.
const ExplodedNode<GRState> *Pred = *(EndN->pred_begin());
ProgramPoint PredPos = Pred->getLocation();
if (PostStmt* PredPS = dyn_cast<PostStmt>(&PredPos)) {
Stmt* SPred = PredPS->getStmt();
// Predecessor at same line?
if (SMgr.getInstantiationLineNumber(SPred->getLocStart()) != EndLine) {
Hint = PathDiagnosticPiece::Below;
S = SPred;
}
}
// Generate the diagnostic. // Generate the diagnostic.
FullSourceLoc L( S->getLocStart(), SMgr); FullSourceLoc L(S->getLocStart(), SMgr);
std::string sbuf; std::string sbuf;
llvm::raw_string_ostream os(sbuf); llvm::raw_string_ostream os(sbuf);
@ -2645,7 +2626,7 @@ CFRefLeakReport::getEndPath(BugReporter& br, const ExplodedNode<GRState>* EndN){
" +" " +"
<< RV->getCount() << " (object leaked)."; << RV->getCount() << " (object leaked).";
return new PathDiagnosticPiece(L, os.str(), Hint); return new PathDiagnosticPiece(L, os.str());
} }