OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

Revert "[clang][Interp] Use placement new to construct opcode args into vector" 

This reverts commit aaf73ae266.

This breaks sanitized builds because the constructor is called with an
unaligned address.
This commit is contained in:
Timm Bäder 2022-11-30 16:07:52 +01:00
parent ec23e5584d
commit 89b009559c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/AST/Interp/ByteCodeEmitter.cpp
View File

@ -163,10 +163,8 @@ static void emit(Program &P, std::vector<char> &Code, const T &Val,
} }
if constexpr (!std::is_pointer_v<T>) { if constexpr (!std::is_pointer_v<T>) {
// Construct the value directly into our storage vector. const char *Data = reinterpret_cast<const char *>(&Val);
size_t ValPos = Code.size(); Code.insert(Code.end(), Data, Data + Size);
Code.resize(Code.size() + Size);
new (Code.data() + ValPos) T(Val);
} else { } else {
uint32_t ID = P.getOrCreateNativePointer(Val); uint32_t ID = P.getOrCreateNativePointer(Val);
const char *Data = reinterpret_cast<const char *>(&ID); const char *Data = reinterpret_cast<const char *>(&ID);