[asan] implement callbacks for unaligned loads/stores

Reviewers: samsonov

Reviewed By: samsonov

CC: samsonov, llvm-commits

Differential Revision: http://llvm-reviews.chandlerc.com/D652

llvm-svn: 179175
This commit is contained in:
Kostya Serebryany 2013-04-10 13:59:32 +00:00
parent 04d9aa4822
commit 92684efb1d
3 changed files with 111 additions and 0 deletions

View File

@ -41,6 +41,16 @@ extern "C" {
// the error message. This function can be overridden by the client.
void __sanitizer_report_error_summary(const char *error_summary);
// Some of the sanitizers (e.g. asan/tsan) may miss bugs that happen
// in unaligned loads/stores. In order to find such bugs reliably one needs
// to replace plain unaligned loads/stores with these calls.
uint16_t __sanitizer_unaligned_load16(const void *p);
uint32_t __sanitizer_unaligned_load32(const void *p);
uint64_t __sanitizer_unaligned_load64(const void *p);
void __sanitizer_unaligned_store16(void *p, uint16_t x);
void __sanitizer_unaligned_store32(void *p, uint32_t x);
void __sanitizer_unaligned_store64(void *p, uint64_t x);
#ifdef __cplusplus
} // extern "C"
#endif

View File

@ -169,6 +169,55 @@ uptr __asan_region_is_poisoned(uptr beg, uptr size) {
return 0;
}
#define CHECK_SMALL_REGION(p, size, isWrite) \
do { \
uptr __p = reinterpret_cast<uptr>(p); \
uptr __size = size; \
if (UNLIKELY(__asan::AddressIsPoisoned(__p) || \
__asan::AddressIsPoisoned(__p + __size - 1))) { \
GET_CURRENT_PC_BP_SP; \
uptr __bad = __asan_region_is_poisoned(__p, __size); \
__asan_report_error(pc, bp, sp, __bad, isWrite, __size);\
} \
} while (false); \
extern "C" SANITIZER_INTERFACE_ATTRIBUTE
u16 __sanitizer_unaligned_load16(const u16 *p) {
CHECK_SMALL_REGION(p, sizeof(*p), false);
return *p;
}
extern "C" SANITIZER_INTERFACE_ATTRIBUTE
u32 __sanitizer_unaligned_load32(const u32 *p) {
CHECK_SMALL_REGION(p, sizeof(*p), false);
return *p;
}
extern "C" SANITIZER_INTERFACE_ATTRIBUTE
u64 __sanitizer_unaligned_load64(const u64 *p) {
CHECK_SMALL_REGION(p, sizeof(*p), false);
return *p;
}
extern "C" SANITIZER_INTERFACE_ATTRIBUTE
void __sanitizer_unaligned_store16(u16 *p, u16 x) {
CHECK_SMALL_REGION(p, sizeof(*p), true);
*p = x;
}
extern "C" SANITIZER_INTERFACE_ATTRIBUTE
void __sanitizer_unaligned_store32(u32 *p, u32 x) {
CHECK_SMALL_REGION(p, sizeof(*p), true);
*p = x;
}
extern "C" SANITIZER_INTERFACE_ATTRIBUTE
void __sanitizer_unaligned_store64(u64 *p, u64 x) {
CHECK_SMALL_REGION(p, sizeof(*p), true);
*p = x;
}
// This is a simplified version of __asan_(un)poison_memory_region, which
// assumes that left border of region to be poisoned is properly aligned.
static void PoisonAlignedStackMemory(uptr addr, uptr size, bool do_poison) {

View File

@ -0,0 +1,52 @@
// RUN: %clangxx_asan -O0 -I %p/../../../include %s -o %t
// RUN: %t A 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-A %s
// RUN: %t B 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-B %s
// RUN: %t C 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-C %s
// RUN: %t D 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-D %s
// RUN: %t E 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-E %s
// RUN: %t K 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-K %s
// RUN: %t L 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-L %s
// RUN: %t M 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-M %s
// RUN: %t N 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-N %s
// RUN: %t O 2>&1 | %symbolize | FileCheck --check-prefix=CHECK-O %s
#include <sanitizer/asan_interface.h>
#include <stdlib.h>
#include <string.h>
int main(int argc, char **argv) {
if (argc != 2) return 1;
char *x = new char[16];
memset(x, 0xab, 16);
int res = 1;
switch (argv[1][0]) {
case 'A': res = __sanitizer_unaligned_load16(x + 15); break;
// CHECK-A ERROR: AddressSanitizer: heap-buffer-overflow on address
// CHECK-A: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-2]]
// CHECK-A: is located 0 bytes to the right of 16-byte region
case 'B': res = __sanitizer_unaligned_load32(x + 14); break;
// CHECK-B: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
case 'C': res = __sanitizer_unaligned_load32(x + 13); break;
// CHECK-C: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
case 'D': res = __sanitizer_unaligned_load64(x + 15); break;
// CHECK-D: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
case 'E': res = __sanitizer_unaligned_load64(x + 9); break;
// CHECK-E: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
case 'K': __sanitizer_unaligned_store16(x + 15, 0); break;
// CHECK-K ERROR: AddressSanitizer: heap-buffer-overflow on address
// CHECK-K: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-2]]
// CHECK-K: is located 0 bytes to the right of 16-byte region
case 'L': __sanitizer_unaligned_store32(x + 15, 0); break;
// CHECK-L: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
case 'M': __sanitizer_unaligned_store32(x + 13, 0); break;
// CHECK-M: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
case 'N': __sanitizer_unaligned_store64(x + 10, 0); break;
// CHECK-N: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
case 'O': __sanitizer_unaligned_store64(x + 14, 0); break;
// CHECK-O: main{{.*}}unaligned_loads_and_stores.cc:[[@LINE-1]]
}
delete x;
return res;
}