From a18761ab9ef2ac81cb1597a387687faa1f254fa0 Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Fri, 1 Feb 2019 20:34:43 +0000 Subject: [PATCH] gn build: Create regular archives for the sanitizer runtimes. We'll need to do this eventually if we create an installable package. For now, this lets me use the archives to build Android, whose build system wants to copy the archives to another location. Differential Revision: https://reviews.llvm.org/D57607 llvm-svn: 352907 --- llvm/utils/gn/build/BUILD.gn | 8 ++++++++ llvm/utils/gn/build/BUILDCONFIG.gn | 1 + llvm/utils/gn/build/toolchain/BUILD.gn | 2 +- .../utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn | 10 ++++++++-- 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/llvm/utils/gn/build/BUILD.gn b/llvm/utils/gn/build/BUILD.gn index 4c5c3bbbb396..cd22d21bcb48 100644 --- a/llvm/utils/gn/build/BUILD.gn +++ b/llvm/utils/gn/build/BUILD.gn @@ -136,6 +136,14 @@ config("no_rtti") { } } +# To make an archive that can be distributed, you need to remove this config and +# set complete_static_lib. +config("thin_archive") { + if (current_os != "win" && current_os != "mac") { + arflags = [ "-T" ] + } +} + config("llvm_code") { include_dirs = [ "//llvm/include", diff --git a/llvm/utils/gn/build/BUILDCONFIG.gn b/llvm/utils/gn/build/BUILDCONFIG.gn index cec736fd8fae..7de638ff3df3 100644 --- a/llvm/utils/gn/build/BUILDCONFIG.gn +++ b/llvm/utils/gn/build/BUILDCONFIG.gn @@ -6,6 +6,7 @@ shared_binary_target_configs = [ "//llvm/utils/gn/build:compiler_defaults", "//llvm/utils/gn/build:llvm_code", "//llvm/utils/gn/build:no_rtti", + "//llvm/utils/gn/build:thin_archive", "//llvm/utils/gn/build:warn_covered_switch_default", ] diff --git a/llvm/utils/gn/build/toolchain/BUILD.gn b/llvm/utils/gn/build/toolchain/BUILD.gn index 4be5e4b8f31b..5ba76d4ea556 100644 --- a/llvm/utils/gn/build/toolchain/BUILD.gn +++ b/llvm/utils/gn/build/toolchain/BUILD.gn @@ -50,7 +50,7 @@ template("unix_toolchain") { # Remove the output file first so that ar doesn't try to modify the # existing file. command = - "rm -f {{output}} && $ar rcsDT {{arflags}} {{output}} {{inputs}}" + "rm -f {{output}} && $ar rcsD {{arflags}} {{output}} {{inputs}}" } description = "AR {{output}}" outputs = [ diff --git a/llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn b/llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn index 5979a6924ec2..fe5870ad7824 100644 --- a/llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn +++ b/llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn @@ -74,7 +74,10 @@ static_library("hwasan") { output_dir = crt_current_out_dir output_name = "clang_rt.hwasan-$crt_current_target" complete_static_lib = true - configs -= [ "//llvm/utils/gn/build:llvm_code" ] + configs -= [ + "//llvm/utils/gn/build:llvm_code", + "//llvm/utils/gn/build:thin_archive", + ] configs += [ "//llvm/utils/gn/build:crt_code" ] deps = [ ":sources", @@ -85,7 +88,10 @@ static_library("hwasan_cxx") { output_dir = crt_current_out_dir output_name = "clang_rt.hwasan_cxx-$crt_current_target" complete_static_lib = true - configs -= [ "//llvm/utils/gn/build:llvm_code" ] + configs -= [ + "//llvm/utils/gn/build:llvm_code", + "//llvm/utils/gn/build:thin_archive", + ] configs += [ "//llvm/utils/gn/build:crt_code" ] deps = [ ":cxx_sources",