From ab5d65e6858b25fc07672a0bd2d07f666bde6b51 Mon Sep 17 00:00:00 2001 From: wlei Date: Mon, 11 Oct 2021 13:40:22 -0700 Subject: [PATCH] [llvm-profgen] Ignore stack samples before aggregation With `ignore-stack-samples`, We can ignore the call stack before the samples aggregation which could reduce some redundant computations. Reviewed By: hoy, wenlei Differential Revision: https://reviews.llvm.org/D111577 --- llvm/tools/llvm-profgen/PerfReader.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/llvm/tools/llvm-profgen/PerfReader.cpp b/llvm/tools/llvm-profgen/PerfReader.cpp index 2aa66832a051..4478cac82c66 100644 --- a/llvm/tools/llvm-profgen/PerfReader.cpp +++ b/llvm/tools/llvm-profgen/PerfReader.cpp @@ -647,9 +647,13 @@ void HybridPerfReader::parseSample(TraceStream &TraceIt, uint64_t Count) { if (!TraceIt.isAtEoF() && TraceIt.getCurrentLine().startswith(" 0x")) { // Parsing LBR stack and populate into PerfSample.LBRStack if (extractLBRStack(TraceIt, Sample->LBRStack)) { - // Canonicalize stack leaf to avoid 'random' IP from leaf frame skew LBR - // ranges - Sample->CallStack.front() = Sample->LBRStack[0].Target; + if (IgnoreStackSamples) { + Sample->CallStack.clear(); + } else { + // Canonicalize stack leaf to avoid 'random' IP from leaf frame skew LBR + // ranges + Sample->CallStack.front() = Sample->LBRStack[0].Target; + } // Record samples by aggregation AggregatedSamples[Hashable(Sample)] += Count; }