OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

[X86] X86tcret_1reg - use cast<> instead of dyn_cast<> to avoid dereference of nullptr 

The pointer is always dereferenced, so assert the cast is correct instead of returning nullptr
This commit is contained in:
Simon Pilgrim 2022-02-17 11:54:12 +00:00
parent f1877eb1bb
commit ada6bcc13f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/Target/X86/X86InstrCompiler.td
View File

@ -1239,8 +1239,7 @@ def X86tcret_1reg : PatFrag<(ops node:$ptr, node:$off),
(X86tcret node:$ptr, node:$off), [{
// X86tcret args: (*chain, ptr, imm, regs..., glue)
unsigned NumRegs = 1;
LoadSDNode* ld = dyn_cast<LoadSDNode>(N->getOperand(1));
const SDValue& BasePtr = ld->getBasePtr();
const SDValue& BasePtr = cast<LoadSDNode>(N->getOperand(1))->getBasePtr();
if (isa<FrameIndexSDNode>(BasePtr))
NumRegs = 3;
else if (BasePtr->getNumOperands() && isa<GlobalAddressSDNode>(BasePtr->getOperand(0)))