OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

Remove unused virtuals from ABISysV_ppc* 

Summary:
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.

They were introduced when the ABISysV_ppc* code was added and weren't
used at the time. The review for the commit that added them can be
found at http://reviews.llvm.org/D5988

The commit comment notes that backtraces don't yet work:

    Backtraces don't work. This is due to PowerPC ABI using a
    backchain pointer in memory, instead of a dedicated frame
    pointer register for the backchain.

So there is a possibility these were added with the intent of using
them in the future.

Reviewers: clayborg, jingham, jhibbits, emaste

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D13506

llvm-svn: 249563
This commit is contained in:
Bruce Mitchener 2015-10-07 16:48:33 +00:00
parent 30f07f9326
commit b8269c7228
2 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
View File

@ -62,12 +62,6 @@ public:
virtual bool virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info); RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
virtual bool
StackUsesFrames ()
{
return true;
}
// The SysV ppc ABI requires that stack frames be 16 byte aligned. // The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland // When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly // code, we've seen that the stack pointer is often not aligned properly
@ -97,12 +91,6 @@ public:
return true; return true;
} }
virtual bool
FunctionCallsChangeCFA ()
{
return true;
}
virtual const lldb_private::RegisterInfo * virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count); GetRegisterInfoArray (uint32_t &count);
//------------------------------------------------------------------ //------------------------------------------------------------------

12
lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
View File

@ -62,12 +62,6 @@ public:
virtual bool virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info); RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
virtual bool
StackUsesFrames ()
{
return true;
}
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned. // The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland // When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly // code, we've seen that the stack pointer is often not aligned properly
@ -97,12 +91,6 @@ public:
return true; return true;
} }
virtual bool
FunctionCallsChangeCFA ()
{
return true;
}
virtual const lldb_private::RegisterInfo * virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count); GetRegisterInfoArray (uint32_t &count);
//------------------------------------------------------------------ //------------------------------------------------------------------