From be0b55d1211a4b38d1e130c3e76d2bbb847c7110 Mon Sep 17 00:00:00 2001 From: Ed Maste Date: Thu, 4 Jul 2013 18:25:34 +0000 Subject: [PATCH] Avoid crash if we fail to resolve process in attach llvm-svn: 185661 --- lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp b/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp index 4e8ed2f8a354..6f25585ad3f8 100644 --- a/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp +++ b/lldb/source/Plugins/Process/POSIX/ProcessPOSIX.cpp @@ -135,6 +135,8 @@ ProcessPOSIX::DoAttachToProcessWithID(lldb::pid_t pid) m_target.GetArchitecture(), exe_module_sp, executable_search_paths.GetSize() ? &executable_search_paths : NULL); + if (!error.Success()) + return error; // Fix the target architecture if necessary const ArchSpec &module_arch = exe_module_sp->GetArchitecture(); @@ -144,9 +146,6 @@ ProcessPOSIX::DoAttachToProcessWithID(lldb::pid_t pid) // Initialize the target module list m_target.SetExecutableModule (exe_module_sp, true); - if (!error.Success()) - return error; - SetSTDIOFileDescriptor(m_monitor->GetTerminalFD()); SetID(pid);