From c171250e3802e52dba4bc3f5c1cb15a1ce29aeac Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 2 Oct 2022 19:49:17 -0700 Subject: [PATCH] [ELF] Simplify addFile. NFC --- lld/ELF/Driver.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp index 7a4853616cb7..2e71282f0f15 100644 --- a/lld/ELF/Driver.cpp +++ b/lld/ELF/Driver.cpp @@ -239,8 +239,9 @@ void LinkerDriver::addFile(StringRef path, bool withLOption) { readLinkerScript(mbref); return; case file_magic::archive: { + auto members = getArchiveMembers(mbref); if (inWholeArchive) { - for (const auto &p : getArchiveMembers(mbref)) { + for (const std::pair &p : members) { if (isBitcode(p.first)) files.push_back(make(p.first, path, p.second, false)); else @@ -249,7 +250,6 @@ void LinkerDriver::addFile(StringRef path, bool withLOption) { return; } - auto members = getArchiveMembers(mbref); archiveFiles.emplace_back(path, members.size()); // Handle archives and --start-lib/--end-lib using the same code path. This