From c46a465eb9860b4427f2fa8c0017ab249ee4d73f Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Tue, 15 Nov 2022 13:50:27 -0800 Subject: [PATCH] [libc] disable flakey tests The mprotect test has been failing and causing significant buildbot noise. Given that this is a simple functions it's more important that the buildbot errors be useful than having more thorough tests for this function. Reviewed By: sivachandra, lntue Differential Revision: https://reviews.llvm.org/D138061 --- libc/test/src/sys/mman/linux/mprotect_test.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libc/test/src/sys/mman/linux/mprotect_test.cpp b/libc/test/src/sys/mman/linux/mprotect_test.cpp index 06e0b51cb9a2..83325461f274 100644 --- a/libc/test/src/sys/mman/linux/mprotect_test.cpp +++ b/libc/test/src/sys/mman/linux/mprotect_test.cpp @@ -43,6 +43,9 @@ TEST(LlvmLibcMProtectTest, NoError) { EXPECT_THAT(__llvm_libc::munmap(addr, alloc_size), Succeeds()); } +// This test is disabled currently due to flakeyness. It will be re-enabled once +// it is less flakey. +/* TEST(LlvmLibcMProtectTest, Error_InvalidWrite) { // attempting to write to a read-only protected part of memory should cause a // segfault. @@ -60,3 +63,4 @@ TEST(LlvmLibcMProtectTest, Error_InvalidWrite) { // Reading from a write only segment may succeed on some platforms, so there's // no test to check that. } +*/