OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

ASan allocates a global data initialization array at the tail end of each 

compunit's .data section. This vector is not poisoned. Because of this the
first symbol of the following section has no left red zone. As a result, ASan
cannot detect underflow for such symbols.

Poison ASan allocated metadata, it should not be accessible to user code.

This fix does not eliminate the problem with missing left red zones but it
reduces the set of vulnerable symbols from first symbols in each input data
section to first symbols in the output section of the binary.

Differential Revision: https://reviews.llvm.org/D38056

llvm-svn: 314365
This commit is contained in:
Dmitry Mikulin 2017-09-27 23:32:01 +00:00
parent 16fee08410
commit d2224e17c3
3 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler-rt/lib/asan/asan_globals.cc
View File

@ -384,6 +384,10 @@ void __asan_register_globals(__asan_global *globals, uptr n) {
}
RegisterGlobal(&globals[i]);
}
// Poison the metadata. It should not be accessible to user code.
PoisonShadow(reinterpret_cast<uptr>(globals), n * sizeof(__asan_global),
kAsanGlobalRedzoneMagic);
}
// Unregister an array of globals.

1
compiler-rt/test/asan/TestCases/Helpers/underflow.cc Normal file
View File

@ -0,0 +1 @@
int YYY[3]={1,2,3};

17
compiler-rt/test/asan/TestCases/global-underflow.cc Normal file
View File

@ -0,0 +1,17 @@
// RUN: %clangxx_asan -O0 %s %p/Helpers/underflow.cc -o %t && not %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O1 %s %p/Helpers/underflow.cc -o %t && not %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O2 %s %p/Helpers/underflow.cc -o %t && not %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O3 %s %p/Helpers/underflow.cc -o %t && not %run %t 2>&1 | FileCheck %s
int XXX[2] = {2, 3};
extern int YYY[];
#include <string.h>
int main(int argc, char **argv) {
memset(XXX, 0, 2*sizeof(int));
// CHECK: {{READ of size 4 at 0x.* thread T0}}
// CHECK: {{ #0 0x.* in main .*global-underflow.cc:}}[[@LINE+3]]
// CHECK: {{0x.* is located 4 bytes to the left of global variable}}
// CHECK: {{.*YYY.* of size 12}}
int res = YYY[-1];
return res;
}