Tab completion for breakpoint write and breakpoint name add/delete
Summary: Apply the common completion created in [[ https://reviews.llvm.org/D75418 | Revision D75418 ]] to the commands `breakpoint write` and `breakpoint name add/delete`. Reviewers: teemperor, JDevlieghere Reviewed By: teemperor Tags: #lldb Differential Revision: https://reviews.llvm.org/D79686
This commit is contained in:
parent
25d6995079
commit
e87362e689
|
|
@ -1770,6 +1770,14 @@ public:
|
||||||
|
|
||||||
~CommandObjectBreakpointNameAdd() override = default;
|
~CommandObjectBreakpointNameAdd() override = default;
|
||||||
|
|
||||||
|
void
|
||||||
|
HandleArgumentCompletion(CompletionRequest &request,
|
||||||
|
OptionElementVector &opt_element_vector) override {
|
||||||
|
CommandCompletions::InvokeCommonCompletionCallbacks(
|
||||||
|
GetCommandInterpreter(), CommandCompletions::eBreakpointCompletion,
|
||||||
|
request, nullptr);
|
||||||
|
}
|
||||||
|
|
||||||
Options *GetOptions() override { return &m_option_group; }
|
Options *GetOptions() override { return &m_option_group; }
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
|
|
@ -1849,6 +1857,14 @@ public:
|
||||||
|
|
||||||
~CommandObjectBreakpointNameDelete() override = default;
|
~CommandObjectBreakpointNameDelete() override = default;
|
||||||
|
|
||||||
|
void
|
||||||
|
HandleArgumentCompletion(CompletionRequest &request,
|
||||||
|
OptionElementVector &opt_element_vector) override {
|
||||||
|
CommandCompletions::InvokeCommonCompletionCallbacks(
|
||||||
|
GetCommandInterpreter(), CommandCompletions::eBreakpointCompletion,
|
||||||
|
request, nullptr);
|
||||||
|
}
|
||||||
|
|
||||||
Options *GetOptions() override { return &m_option_group; }
|
Options *GetOptions() override { return &m_option_group; }
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
|
|
@ -2147,6 +2163,14 @@ public:
|
||||||
|
|
||||||
~CommandObjectBreakpointWrite() override = default;
|
~CommandObjectBreakpointWrite() override = default;
|
||||||
|
|
||||||
|
void
|
||||||
|
HandleArgumentCompletion(CompletionRequest &request,
|
||||||
|
OptionElementVector &opt_element_vector) override {
|
||||||
|
CommandCompletions::InvokeCommonCompletionCallbacks(
|
||||||
|
GetCommandInterpreter(), CommandCompletions::eBreakpointCompletion,
|
||||||
|
request, nullptr);
|
||||||
|
}
|
||||||
|
|
||||||
Options *GetOptions() override { return &m_options; }
|
Options *GetOptions() override { return &m_options; }
|
||||||
|
|
||||||
class CommandOptions : public Options {
|
class CommandOptions : public Options {
|
||||||
|
|
|
||||||
|
|
@ -478,10 +478,10 @@ class CommandLineCompletionTestCase(TestBase):
|
||||||
self.complete_from_to('register write rbx ',
|
self.complete_from_to('register write rbx ',
|
||||||
[])
|
[])
|
||||||
|
|
||||||
def test_breakpoint_enable_disable_delete_modify_with_ids(self):
|
def test_complete_breakpoint_with_ids(self):
|
||||||
"""These four breakpoint subcommands should be completed with a list of breakpoint ids"""
|
"""These breakpoint subcommands should be completed with a list of breakpoint ids"""
|
||||||
|
|
||||||
subcommands = ['enable', 'disable', 'delete', 'modify']
|
subcommands = ['enable', 'disable', 'delete', 'modify', 'name add', 'name delete', 'write']
|
||||||
|
|
||||||
# The tab completion here is unavailable without a target
|
# The tab completion here is unavailable without a target
|
||||||
for subcommand in subcommands:
|
for subcommand in subcommands:
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue