From ed98b68ed841abe6a7de08402a84f76d2cf29a89 Mon Sep 17 00:00:00 2001 From: David Majnemer Date: Thu, 20 Mar 2014 06:28:55 +0000 Subject: [PATCH] Object: Abstract out the determination of function line symbols No functionality change. llvm-svn: 204313 --- llvm/include/llvm/Object/COFF.h | 4 ++++ llvm/tools/obj2yaml/coff2yaml.cpp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/llvm/include/llvm/Object/COFF.h b/llvm/include/llvm/Object/COFF.h index 0f24c1b8e51e..31b7d6ea174f 100644 --- a/llvm/include/llvm/Object/COFF.h +++ b/llvm/include/llvm/Object/COFF.h @@ -210,6 +210,10 @@ struct coff_symbol { !COFF::isReservedSectionNumber(SectionNumber); } + bool isFunctionLineInfo() const { + return StorageClass == COFF::IMAGE_SYM_CLASS_FUNCTION; + } + bool isWeakExternal() const { return StorageClass == COFF::IMAGE_SYM_CLASS_WEAK_EXTERNAL || (StorageClass == COFF::IMAGE_SYM_CLASS_EXTERNAL && diff --git a/llvm/tools/obj2yaml/coff2yaml.cpp b/llvm/tools/obj2yaml/coff2yaml.cpp index b003029407ca..1542506e5f9b 100644 --- a/llvm/tools/obj2yaml/coff2yaml.cpp +++ b/llvm/tools/obj2yaml/coff2yaml.cpp @@ -157,7 +157,7 @@ void COFFDumper::dumpSymbols(unsigned NumSymbols) { reinterpret_cast( AuxData.data()); dumpFunctionDefinition(&Sym, ObjFD); - } else if (Symbol->StorageClass == COFF::IMAGE_SYM_CLASS_FUNCTION) { + } else if (Symbol->isFunctionLineInfo()) { // This symbol describes function line number information. assert(Symbol->NumberOfAuxSymbols == 1 && "Exepected a single aux symbol to describe this section!");