llvm-project

Author SHA1 Message Date

Author	SHA1	Message	Date
Fangrui Song	5c29ffda90	Revert "[Driver][test] Replace ^//$ with empty string" This reverts commit `4817b7729a`. It caused some `^/\n` and had some objection about its readability improvement.	2022-06-24 13:52:27 -07:00
Fangrui Song	4817b7729a	[Driver][test] Replace ^//$ with empty string The convention does not add //\n. Having all RUN/CHECK lines separated by //\n makes editor movement difficult (e.g. { } in Vim).	2022-06-24 11:25:03 -07:00
Vedant Kumar	e05baf40de	[InitLLVM] Ensure SIGPIPE handler installed before sigaction() The pipe signal handler must be installed before any other handlers are registered. This is because the Unix RegisterHandlers function does not perform a sigaction() for SIGPIPE unless a one-shot handler is present, to allow long-lived processes (like lldb) to fully opt-out of llvm's SIGPIPE handling and ignore the signal safely. Fixes a bug introduced in D70277. Tested by running Nick's test case: % xcrun ./bin/clang -E -fno-integrated-cc1 x.c \| tee foo.txt \| head I verified that child cc1 process exits with IO_ERR, and that the parent recognizes the error code, exiting cleanly. Differential Revision: https://reviews.llvm.org/D94324	2021-01-08 15:13:04 -08:00

Fangrui Song

5c29ffda90

Revert "[Driver][test] Replace ^//$ with empty string"

This reverts commit 4817b7729a.

It caused some `^/\n` and had some objection about its readability improvement.

2022-06-24 13:52:27 -07:00

Fangrui Song

4817b7729a

[Driver][test] Replace ^//$ with empty string

The convention does not add //\n. Having all RUN/CHECK lines separated by //\n
makes editor movement difficult (e.g. { } in Vim).

2022-06-24 11:25:03 -07:00

Vedant Kumar

e05baf40de

[InitLLVM] Ensure SIGPIPE handler installed before sigaction()

The pipe signal handler must be installed before any other handlers are
registered. This is because the Unix RegisterHandlers function does not
perform a sigaction() for SIGPIPE unless a one-shot handler is present,
to allow long-lived processes (like lldb) to fully opt-out of llvm's
SIGPIPE handling and ignore the signal safely.

Fixes a bug introduced in D70277.

Tested by running Nick's test case:

% xcrun ./bin/clang -E -fno-integrated-cc1 x.c | tee foo.txt | head

I verified that child cc1 process exits with IO_ERR, and that the parent
recognizes the error code, exiting cleanly.

Differential Revision: https://reviews.llvm.org/D94324

2021-01-08 15:13:04 -08:00

3 Commits