611ffcf4e4
[llvm] Use value instead of getValue (NFC)
2022-07-13 23:11:56 -07:00
3361a364e6
[llvm] Use has_value instead of hasValue (NFC)
2022-07-12 22:25:42 -07:00
3c126d5fe4
[Alignment] Replace commonAlignment with std::min
...
`commonAlignment` is a shortcut to pick the smallest of two `Align`
objects. As-is it doesn't bring much value compared to `std::min`.
Differential Revision: https://reviews.llvm.org/D128345
2022-06-28 07:15:02 +00:00
3b7c3a654c
Revert "Don't use Optional::hasValue (NFC)"
...
This reverts commit aa8feeefd3
2022-06-25 11:56:50 -07:00
aa8feeefd3
Don't use Optional::hasValue (NFC)
2022-06-25 11:55:57 -07:00
d152e50c15
[llvm] Don't use Optional::{hasValue,getValue} (NFC)
2022-06-25 11:24:23 -07:00
1baf1fc276
[NFC] Remove dead code
2022-06-25 17:18:45 +00:00
57ffff6db0
Revert "[NFC] Remove dead code"
...
This reverts commit 8ba2cbff70
2022-06-22 14:55:47 +00:00
8ba2cbff70
[NFC] Remove dead code
2022-06-22 13:33:58 +00:00
9803db8c18
[NFC] Remove dead code
2022-06-22 13:13:01 +00:00
d3cf49e984
[Alignment] Remove alignTo version taking a MaybeAlign
2022-06-20 15:15:53 +00:00
03036061c7
[Alignment] Use 'previous()' method instead of scalar division
...
This is in preparation of integration with D128052.
Differential Revision: https://reviews.llvm.org/D128169
2022-06-20 11:01:43 +00:00
f1255186c7
[NFC][Alignment] Remove max functions between Align and MaybeAlign
...
`llvm::max(Align, MaybeAlign)` and `llvm::max(MaybeAlign, Align)` are
not used often enough to be required. They also make the code more opaque.
Differential Revision: https://reviews.llvm.org/D128121
2022-06-20 08:37:48 +00:00
17e68156f6
[NFC][Alignment] Remove dead code
2022-06-18 15:00:55 +00:00
7392820f98
[Align] Remove operations on MaybeAlign that asserted that it had a defined value.
...
If the caller needs to reponsible for making sure the MaybeAlign
has a value, then we should just make the caller convert it to an Align
with operator*.
I explicitly deleted the relational comparison operators that
were being inherited from Optional. It's unclear what the meaning
of two MaybeAligns were one is defined and the other isn't
should be. So make the caller reponsible for defining the behavior.
I left the ==/!= operators from Optional. But now that exposed a
weird quirk that ==/!= between Align and MaybeAlign required the
MaybeAlign to be defined. But now we use the operator== from
Optional that takes an Optional and the Value.
Differential Revision: https://reviews.llvm.org/D80455
2020-05-22 21:54:28 -07:00
a060a1782e
[Alignment] Add alignTo with skew parameter
...
Summary: courbet
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76274
2020-03-17 15:54:47 +01:00
805c157e8a
[Alignment][NFC] Deprecate Align::None()
...
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262 .
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-24 12:53:58 +01:00
da68fd8f81
Fix https://bugs.llvm.org/show_bug.cgi?id=43791
2019-10-28 10:40:35 +01:00
ce56e1a1cc
[Alignment][NFC] Move and type functions from MathExtras to Alignment
...
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68942
llvm-svn: 374773
2019-10-14 13:14:34 +00:00
415df89e22
[Alignment][NFC] Support compile time constants
...
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68936
llvm-svn: 374758
2019-10-14 09:04:15 +00:00
d1f23bd225
Revert "[Alignment][NFC] Allow constexpr Align"
...
This reverts commit b3af236fb5
2019-10-03 15:53:50 +00:00
b3af236fb5
[Alignment][NFC] Allow constexpr Align
...
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68329
llvm-svn: 373580
2019-10-03 10:53:10 +00:00
02c19658ff
[Alignment][NFC] Adding a max function.
...
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68201
llvm-svn: 373196
2019-09-30 09:59:31 +00:00
ef8ef1278a
[Alignment] Add a None() member function
...
Summary:
This will allow writing `if(A != llvm::Align::None())` which is clearer than `if(A > llvm::Align(1))`
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67697
llvm-svn: 372207
2019-09-18 09:24:40 +00:00
1c013ca1f2
[LLVM][Alignment] Fix MSVC potential division by 0 warning (PR42911)
...
Original Patch by @gchatelet (Guillaume Chatelet)
Differential Revision: https://reviews.llvm.org/D65859
llvm-svn: 369016
2019-08-15 16:34:23 +00:00
396521378f
[LLVM][Alignment] Introduce Alignment In GlobalObject
...
Summary:
This is patch is part of a serie to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: jfb
Subscribers: hiraditya, dexonsmith, llvm-commits, courbet
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65748
Address comments
llvm-svn: 368000
2019-08-06 09:03:21 +00:00
383650c7f1
Add brackets to remove warnings about ambiguous 'else's.
...
llvm-svn: 367740
2019-08-03 00:26:10 +00:00
41dfc69dc7
[LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t
...
Reviewers: yroux
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65563
llvm-svn: 367532
2019-08-01 09:20:00 +00:00
10dd2965b7
[LLVM] Fix Alignment death tests in Release Mode
...
llvm-svn: 367427
2019-07-31 12:47:20 +00:00
c87581c4d4
Fix mismatching vector type in AlignmentTest.cpp
...
llvm-svn: 367404
2019-07-31 10:00:48 +00:00
ac4869197f
[LLVM][NFC] Adding an Alignment type to LLVM
...
Summary:
This patch introduces a type to straighten LLVM's alignment management.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
The next step is to use this type throughout LLVM
Reviewers: jfb, jakehehrlich
Subscribers: mgorny, mgrang, dexonsmith, llvm-commits, courbet
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D64790
llvm-svn: 367393
2019-07-31 08:27:42 +00:00
Kazu Hirata