llvm-project

Commit Graph

Author	SHA1	Message	Date
Pavel Labath	c69d0a203b	Fix new Log unit test the test was flaky because I specified the format string for the process id incorrectly. This should fix it. llvm-svn: 292414	2017-01-18 17:31:55 +00:00
Pavel Labath	a92d6230da	Fix windows build for previous commit We get an error about a redefinition of getcwd(). This seems to fix it. llvm-svn: 292364	2017-01-18 12:29:51 +00:00
Pavel Labath	107d9bbd6c	Add a more succinct logging syntax This adds the LLDB_LOG macro, which enables one to write more succinct log statements. if (log) log->Printf("log something: %d", var); becomes LLDB_LOG(log, "log something: {0}, var); The macro still internally does the "if(log)" dance, so the arguments are only evaluated if logging is enabled, meaning it has the same overhead as the previous syntax. Additionally, the log statements will be automatically prefixed with the file and function generating the log (if the corresponding new argument to the "log enable" command is enabled), so one does not need to manually specify this in the log statement. It also uses the new llvm formatv syntax, which means we don't have to worry about PRIx64 macros and similar, and we can log complex object (llvm::StringRef, lldb_private::Error, ...) more easily. Differential Revision: https://reviews.llvm.org/D27459 llvm-svn: 292360	2017-01-18 11:00:26 +00:00

Author

SHA1

Message

Date

Pavel Labath

c69d0a203b

Fix new Log unit test

the test was flaky because I specified the format string for the process id
incorrectly. This should fix it.

llvm-svn: 292414

2017-01-18 17:31:55 +00:00

Pavel Labath

a92d6230da

Fix windows build for previous commit

We get an error about a redefinition of getcwd(). This seems to fix it.

llvm-svn: 292364

2017-01-18 12:29:51 +00:00

Pavel Labath

107d9bbd6c

Add a more succinct logging syntax

This adds the LLDB_LOG macro, which enables one to write more succinct log
statements.
if (log)
  log->Printf("log something: %d", var);
becomes
LLDB_LOG(log, "log something: {0}, var);

The macro still internally does the "if(log)" dance, so the arguments are only
evaluated if logging is enabled, meaning it has the same overhead as the
previous syntax.

Additionally, the log statements will be automatically prefixed with the file
and function generating the log (if the corresponding new argument to the "log
enable" command is enabled), so one does not need to manually specify this in
the log statement.

It also uses the new llvm formatv syntax, which means we don't have to worry
about PRIx64 macros and similar, and we can log complex object (llvm::StringRef,
lldb_private::Error, ...) more easily.

Differential Revision: https://reviews.llvm.org/D27459

llvm-svn: 292360

2017-01-18 11:00:26 +00:00

3 Commits