llvm-project

Commit Graph

Author	SHA1	Message	Date
Martin Boehme	86866107b8	[Clang] Fix: Restore warning inadvertently removed by D126061. Before D126061, Clang would warn about this code ``` struct X { [[deprecated]] struct Y {}; }; ``` with the warning attribute 'deprecated' is ignored, place it after "struct" to apply attribute to type declaration D126061 inadvertently caused this warning to no longer be emitted. This patch restores the previous behavior. The reason for the bug is that after D126061, C++11 attributes applied to a member declaration are no longer placed in `DS.getAttributes()` but are instead tracked in a separate list (`DeclAttrs`). In the case of a free-standing decl-specifier-seq, we would simply ignore the contents of this list. Instead, we now pass the list on to `Sema::ParsedFreeStandingDeclSpec()` so that it can issue the appropriate warning. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D128499	2022-06-28 08:52:58 +02:00
Chandler Carruth	bc40eef82b	Remove some extraneous carriage returns from these files. One of the Windows subversion clients isn't setup to default to eol:native again... llvm-svn: 146952	2011-12-20 01:45:15 +00:00
Eli Friedman	e321795c60	Remove a non-gcc-compatible extension that would apply attributes on declarations without a declarator to structs. Add a warning for ignored attributes. Patch by Michael Han. llvm-svn: 146796	2011-12-17 00:36:09 +00:00

Author

SHA1

Message

Date

Martin Boehme

86866107b8

[Clang] Fix: Restore warning inadvertently removed by D126061.

Before D126061, Clang would warn about this code

```
struct X {
    [[deprecated]] struct Y {};
};
```

with the warning

    attribute 'deprecated' is ignored, place it after "struct" to apply attribute to type declaration

D126061 inadvertently caused this warning to no longer be emitted. This patch
restores the previous behavior.

The reason for the bug is that after D126061, C++11 attributes applied to a
member declaration are no longer placed in `DS.getAttributes()` but are instead
tracked in a separate list (`DeclAttrs`). In the case of a free-standing
decl-specifier-seq, we would simply ignore the contents of this list. Instead,
we now pass the list on to `Sema::ParsedFreeStandingDeclSpec()` so that it can
issue the appropriate warning.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D128499

2022-06-28 08:52:58 +02:00

Chandler Carruth

bc40eef82b

Remove some extraneous carriage returns from these files. One of the

Windows subversion clients isn't setup to default to eol:native again...

llvm-svn: 146952

2011-12-20 01:45:15 +00:00

Eli Friedman

e321795c60

Remove a non-gcc-compatible extension that would apply attributes on declarations without a declarator to structs. Add a warning for ignored attributes. Patch by Michael Han.

llvm-svn: 146796

2011-12-17 00:36:09 +00:00

3 Commits