5 Commits

Author	SHA1	Message	Date
Nathan James	54f57d3847	[clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS ... Add a fix-it for the common case of setters/constructors using parameters with the same name as fields ```lang=c++ struct A{ int X; A(int X) { /*this->*/X = X; } void setX(int X) { /*this->*/X = X; }; ``` Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D129202	2022-07-09 08:28:07 +01:00
Richard Smith	f6a5ab6c8c	Use builtin recognition to detect std::move / std::forward. ... Replaces some prior ad-hoc detection strategies and generally cleans up a little. No functional change intended.	2022-04-21 14:21:07 -07:00
Corentin Jabot	70b1f6de53	[clang] Warn on unqualified calls to std::move and std::forward ... This adds a diagnostic when an unqualified call is resolved to std::move or std::forward. This follows some C++ committee discussions where some people where concerns that this might be an usual anti pattern particularly britle worth warning about - both because move is a common name and because these functions accept any values. This warns inconditionnally of whether the current context is in std:: or not, as implementations probably want to always qualify these calls too, to avoid triggering adl accidentally. Differential Revision: https://reviews.llvm.org/D119670	2022-02-24 07:23:39 -08:00
Richard Trieu	36d0b2b49f	Extend the self move warning to record types. ... Move the logic for checking self moves into SemaChecking and add that function to Sema since it is now used in multiple places. llvm-svn: 225756	2015-01-13 02:32:02 +00:00
Richard Trieu	17ddb829aa	Add a new warning, -Wself-move, to Clang. ... -Wself-move is similiar to -Wself-assign. This warning is triggered when a value is attempted to be moved to itself. See r221008 for a bug that would have been caught with this warning. llvm-svn: 225581	2015-01-10 06:04:18 +00:00