f0f38d9b9d
[llvm-objdump] - Cleanup the error reporting.
...
The error reporting function are not consistent.
Before this change:
* They had inconsistent naming (e.g. 'error' vs 'report_error').
* Some of them reported the object name, others - dont.
* Some of them accepted the case when there was no error. (i.e. error code or Error had a success value).
This patch tries to cleanup it a bit.
It also renames report_error -> reportError, report_warning -> reportWarning
and removes a full stop from messages.
Differential revision: https://reviews.llvm.org/D66418
llvm-svn: 369515
2019-08-21 11:07:31 +00:00
c5f8aa8bea
[llvm-objdump] Keep warning for --disassemble-functions in correct order.
...
relative to normal output when dumping archive files.
prepare for PR35351.
Reviewers: jhenderson, grimar, MaskRay, rupprecht
Reviewed by: MaskRay, jhenderson
Differential Revision: https://reviews.llvm.org/D64165
llvm-svn: 365564
2019-07-09 21:53:33 +00:00
c3c18f4a0d
[llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol
...
Summary:
Fixes Bug 41904 https://bugs.llvm.org/show_bug.cgi?id=41904
Re-land r362768 after it was reverted in r362826.
Reviewers: jhenderson, rupprecht, grimar, MaskRay
Reviewed By: jhenderson, rupprecht, MaskRay
Subscribers: dexonsmith, rupprecht, kristina, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D62275
llvm-svn: 362838
2019-06-07 20:34:31 +00:00
e67f6206ac
Revert "[llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol"
...
This reverts commit 50f61af3f30bddef7901
2019-06-07 18:55:12 +00:00
50f61af3f3
[llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol
...
Summary: Fixes Bug 41904 https://bugs.llvm.org/show_bug.cgi?id=41904
Reviewers: jhenderson, rupprecht, grimar, MaskRay
Reviewed By: jhenderson, rupprecht, MaskRay
Subscribers: dexonsmith, rupprecht, kristina, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D62275
llvm-svn: 362768
2019-06-07 05:11:13 +00:00
George Rimar