llvm-project

Commit Graph

Author	SHA1	Message	Date
Mark de Wever	8f972cb0fd	[libc++][nfc] Add TEST_HAS_NO_INT128. Avoid using the libc++ internal `_LIBCPP_HAS_NO_INT128` in our tests. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D117992	2022-01-27 17:31:27 +01:00
Mark de Wever	5d3ab6a2bb	[libc++][nfc] Include test_macros.h in more tests. This should fix the regressions detected in D117992. This lands before D117992 to avoid breaking main. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D118056	2022-01-27 17:28:26 +01:00
Ruslan Arutyunyan	8ce2675b13	[libc++][compare] Implement three_way_comparable[_with] concepts Implementation of `three_way_comparable` and `three_way_comparable_with` concepts from <compare> header. Please note that I have temporarily removed `<compare>` header from `<utility>` due to cyclic dependency that prevents using `<concepts>` header in `<compare>` one. I tried to quickly resolve those issues including applying suggestions from @cjdb and dive deeper by myself but the problem seems more complicated that we thought initially. I am in progress to prepare the patch with resolving this cyclic dependency between headers but for now I decided to put all that I have to the review to unblock people that depend on that functionality. At first glance the patch with resolving cyclic dependency is not so small (unless I find the way to make it smaller and cleaner) so I don't want to mix everything to one review. Reviewed By: ldionne, cjdb, #libc, Quuxplusone Differential Revision: https://reviews.llvm.org/D103478	2021-09-05 12:38:08 -07:00

Author

SHA1

Message

Date

Mark de Wever

8f972cb0fd

[libc++][nfc] Add TEST_HAS_NO_INT128.

Avoid using the libc++ internal `_LIBCPP_HAS_NO_INT128` in our tests.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D117992

2022-01-27 17:31:27 +01:00

Mark de Wever

5d3ab6a2bb

[libc++][nfc] Include test_macros.h in more tests.

This should fix the regressions detected in D117992.

This lands before D117992 to avoid breaking main.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D118056

2022-01-27 17:28:26 +01:00

Ruslan Arutyunyan

8ce2675b13

[libc++][compare] Implement three_way_comparable[_with] concepts

Implementation of `three_way_comparable` and `three_way_comparable_with` concepts from <compare> header.

Please note that I have temporarily removed `<compare>` header from `<utility>` due to cyclic dependency that prevents using `<concepts>` header in `<compare>` one.

I tried to quickly resolve those issues including applying suggestions from @cjdb and dive deeper by myself but the problem seems more complicated that we thought initially.

I am in progress to prepare the patch with resolving this cyclic dependency between headers but for now I decided to put all that I have to the review to unblock people that depend on that functionality. At first glance the patch with resolving cyclic dependency is not so small (unless I find the way to make it smaller and cleaner) so I don't want to mix everything to one review.

Reviewed By: ldionne, cjdb, #libc, Quuxplusone

Differential Revision: https://reviews.llvm.org/D103478

2021-09-05 12:38:08 -07:00

3 Commits