llvm-project

Commit Graph

Author	SHA1	Message	Date
Florian Hahn	e43e8e9138	[AnnotationRemarks] Use subprogram location for summary remarks. The summary remarks are generated on a per-function basis. Using the first instruction's location is sub-optimal for 2 reasons: 1. Sometimes the first instruction is missing !dbg 2. The location of the first instruction may be mis-leading. Instead, just use the location of the function directly.	2021-03-23 12:05:41 +00:00
Florian Hahn	4ed0a5506a	[AnnotationRemarks] Add test for annotation remarks with dbg locations. The test illustrates that we not pick the debug location from the function directly. This will be fixed in a follow-up patch.	2021-03-23 11:52:27 +00:00

Author

SHA1

Message

Date

Florian Hahn

e43e8e9138

[AnnotationRemarks] Use subprogram location for summary remarks.

The summary remarks are generated on a per-function basis. Using the
first instruction's location is sub-optimal for 2 reasons:
  1. Sometimes the first instruction is missing !dbg
  2. The location of the first instruction may be mis-leading.

Instead, just use the location of the function directly.

2021-03-23 12:05:41 +00:00

Florian Hahn

4ed0a5506a

[AnnotationRemarks] Add test for annotation remarks with dbg locations.

The test illustrates that we not pick the debug location from the
function directly. This will be fixed in a follow-up patch.

2021-03-23 11:52:27 +00:00

2 Commits