6432afe50c
Summary:
When I wrote `ObjCHeaderStyleGuesser`, I incorrectly assumed the
correct way to iterate over all tokens in `AnnotatedLine` was to
iterate over the linked list tokens starting with
`AnnotatedLine::First`.
However, `AnnotatedLine` also contains a vector
`AnnotedLine::Children` with child `AnnotedLine`s which have their own
tokens which we need to iterate over.
Because I didn't iterate over the tokens in the children lines, the
ObjC style guesser would fail on syntax like:
#define FOO ({ NSString *s = ... })
as the statement(s) inside { ... } are child lines.
This fixes the bug and adds a test. I confirmed the test
failed before the fix, and passed after the fix.
Test Plan: New tests added. Ran tests with:
% make -j12 FormatTests && ./tools/clang/unittests/Format/FormatTests
Reviewers: djasper, jolesiak, Wizard
Reviewed By: djasper
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D44790
llvm-svn: 328220
|
||
|---|---|---|
| .. | ||
| AST | ||
| ASTMatchers | ||
| Analysis | ||
| Basic | ||
| CodeGen | ||
| CrossTU | ||
| Driver | ||
| Format | ||
| Frontend | ||
| Lex | ||
| Rename | ||
| Rewrite | ||
| Sema | ||
| StaticAnalyzer | ||
| Tooling | ||
| libclang | ||
| CMakeLists.txt | ||