OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity
llvm-project/clang-tools-extra/clangd/unittests
History
Vassil Vassilev 0cb7e7ca0c Make iteration over the DeclContext::lookup_result safe. 
The idiom:
```
DeclContext::lookup_result R = DeclContext::lookup(Name);
for (auto *D : R) {...}
```

is not safe when in the loop body we trigger deserialization from an AST file.
The deserialization can insert new declarations in the StoredDeclsList whose
underlying type is a vector. When the vector decides to reallocate its storage
the pointer we hold becomes invalid.

This patch replaces a SmallVector with an singly-linked list. The current
approach stores a SmallVector<NamedDecl*, 4> which is around 8 pointers.
The linked list is 3, 5, or 7. We do better in terms of memory usage for small
cases (and worse in terms of locality -- the linked list entries won't be near
each other, but will be near their corresponding declarations, and we were going
to fetch those memory pages anyway). For larger cases: the vector uses a
doubling strategy for reallocation, so will generally be between half-full and
full. Let's say it's 75% full on average, so there's N * 4/3 + 4 pointers' worth
of space allocated currently and will be 2N pointers with the linked list. So we
break even when there are N=6 entries and slightly lose in terms of memory usage
after that. We suspect that's still a win on average.

Thanks to @rsmith!

Differential revision: https://reviews.llvm.org/D91524
 		2021-03-17 08:59:04 +00:00
..
decision_forest_model Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code completion."" 2020-09-19 10:54:04 +02:00
remote [clangd] Add symbol origin for remote index 2020-11-28 15:38:11 +01:00
support [clangd] Fix windows buildbots after ecea7218fb 2021-02-16 20:57:08 +01:00
tweaks [clangd] Drop explicit specifier on define out-of-line 2021-03-11 13:27:24 +01:00
xpc
…
ASTSignalsTests.cpp [clangd] Make AST-based signals available to runWithPreamble. 2021-01-14 18:34:50 +01:00
ASTTests.cpp Revert "[clangd] Extract symbol-scope logic out of Quality, add tests. NFC" 2021-01-29 14:59:16 +01:00
Annotations.cpp
…
Annotations.h
…
BackgroundIndexTests.cpp [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge 2021-02-05 13:35:07 +03:00
CMakeLists.txt [clangd] Treat paths case-insensitively depending on the platform 2021-02-16 20:20:53 +01:00
CallHierarchyTests.cpp [clangd] Sort results of incomingCalls request by container name 2020-11-24 03:29:02 -05:00
CanonicalIncludesTests.cpp [clangd] Group filename calculations in SymbolCollector, and cache mroe. 2021-03-11 12:59:26 +01:00
ClangdLSPServerTests.cpp [clangd] Move logging out of LSPTest base class into a separate one. 2021-03-09 11:57:05 +01:00
ClangdTests.cpp [clangd] Move DraftStore from ClangdLSPServer into ClangdServer. 2021-03-02 22:58:50 +01:00
CodeCompleteTests.cpp [CodeCompletion] Avoid spurious signature help for init-list args 2021-03-16 12:46:40 +01:00
CodeCompletionStringsTests.cpp [clangd] Fix invalid UTF8 when extracting doc comments. 2020-09-30 16:05:12 +02:00
CollectMacrosTests.cpp [clangd] Add main file macros into the main-file index. 2021-01-14 15:10:17 +03:00
CompileCommandsTests.cpp Reland [clangd] Quote/escape argv included in log messages. 2021-01-31 16:39:47 +01:00
CompilerTests.cpp [clangd] Don't crash on `#pragma clang __debug parser_crash` 2020-08-20 15:53:21 +03:00
ConfigCompileTests.cpp [clangd] Add config block for Completion and option for AllScopes 2021-03-11 20:30:35 +01:00
ConfigProviderTests.cpp [clangd] Provide suggestions with invalid config keys 2020-12-15 18:16:17 +00:00
ConfigTesting.h [clangd] Publish config file errors over LSP 2020-12-07 11:07:32 +01:00
ConfigYAMLTests.cpp [clangd] Add config block for Completion and option for AllScopes 2021-03-11 20:30:35 +01:00
DecisionForestTests.cpp Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code completion."" 2020-09-19 10:54:04 +02:00
DexTests.cpp [clangd] Use URIs instead of paths in the index file list 2021-03-06 10:47:05 +03:00
DiagnosticsTests.cpp [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
DraftStoreTests.cpp [clangd] Add a Filesystem that overlays Dirty files. 2021-03-09 14:35:21 +00:00
DumpASTTests.cpp [clangd] Mention when CXXThis is implicit in exposed AST. 2020-11-24 16:57:56 +01:00
ExpectedTypeTest.cpp Make llvm::StringRef to std::string conversions explicit. 2020-01-28 23:25:25 +01:00
FSTests.cpp [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory 2020-06-19 12:12:02 +02:00
FileDistanceTests.cpp
…
FileIndexTests.cpp [clangd] Use URIs instead of paths in the index file list 2021-03-06 10:47:05 +03:00
FindSymbolsTests.cpp [clangd] Make WorkspaceSymbols request work with empty queries 2021-03-03 15:41:39 +01:00
FindTargetTests.cpp [clangd] ObjC fixes for semantic highlighting and xref highlights 2021-03-03 20:16:08 +01:00
FormatTests.cpp
…
FuzzyMatchTests.cpp [ADT] Make StringRef's std::string conversion operator explicit 2020-01-28 23:47:07 +01:00
GlobalCompilationDatabaseTests.cpp Reland [clangd] Quote/escape argv included in log messages. 2021-01-31 16:39:47 +01:00
HeaderSourceSwitchTests.cpp [clangd][NFC] Rename FSProvider and getFileSystem 2020-06-19 12:12:03 +02:00
HeadersTests.cpp [clangd] Rename FSProvider to TFS in case of ThreadsafeFS 2020-06-19 12:12:03 +02:00
HoverTests.cpp [clangd] Show hex value of numeric constants 2021-03-02 16:33:02 +01:00
IndexActionTests.cpp [clangd] Don't traverse the AST within uninteresting files during indexing 2020-05-26 10:27:28 +02:00
IndexTests.cpp [clangd] Use URIs instead of paths in the index file list 2021-03-06 10:47:05 +03:00
JSONTransportTests.cpp [clangd] Move non-clang base pieces into separate support/ lib. NFCI 2020-04-29 15:57:12 +02:00
LSPBinderTests.cpp [clangd] Bind outgoing calls through LSPBinder too. NFC 2021-02-17 10:56:06 +01:00
LSPClient.cpp [clangd] Metric tracking through Tracer 2020-05-03 10:50:32 +02:00
LSPClient.h [clangd] Set up machinery for gtests of ClangdLSPServer. 2020-04-10 02:50:57 +02:00
LoggerTests.cpp [clangd] Add error() function for creating formatv-style llvm::Errors. NFC 2020-09-14 10:43:42 +02:00
Matchers.h
…
ModulesTests.cpp [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
ParsedASTTests.cpp [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
PathMappingTests.cpp [clang-tools-extra] NFC: Fix trivial typo in documents and comments 2020-04-05 15:28:40 +09:00
PreambleTests.cpp [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
PrintASTTests.cpp [clangd] Errors in TestTU cause test failures unless suppressed with error-ok. 2020-01-24 11:16:27 +01:00
ProjectAwareIndexTests.cpp [clangd] Make ProjectAwareIndex optionally sync 2021-03-11 20:30:35 +01:00
QualityTests.cpp Revert "[clangd] Extract symbol-scope logic out of Quality, add tests. NFC" 2021-01-29 14:59:16 +01:00
RIFFTests.cpp
…
RenameTests.cpp [clangd] Reject renames to non-identifier characters 2021-03-16 12:18:29 +01:00
SelectionTests.cpp [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
SemanticHighlightingTests.cpp [clangd] ObjC fixes for semantic highlighting and xref highlights 2021-03-03 20:16:08 +01:00
SemanticSelectionTests.cpp [clangd] Start using SyntaxTrees for folding ranges feature 2020-10-27 16:47:35 +01:00
SerializationTests.cpp [clangd] Express ASAN interactions of tests more clearly. NFC 2020-11-19 20:14:51 +01:00
SourceCodeTests.cpp [clangd] Move DraftStore from ClangdLSPServer into ClangdServer. 2021-03-02 22:58:50 +01:00
SymbolCollectorTests.cpp [clangd] Group filename calculations in SymbolCollector, and cache mroe. 2021-03-11 12:59:26 +01:00
SymbolInfoTests.cpp [clang-tools-extra] NFC: Fix trivial typo in documents and comments 2020-04-05 15:28:40 +09:00
SyncAPI.cpp [clangd] Move DraftStore from ClangdLSPServer into ClangdServer. 2021-03-02 22:58:50 +01:00
SyncAPI.h [clangd] Move DraftStore from ClangdLSPServer into ClangdServer. 2021-03-02 22:58:50 +01:00
TUSchedulerTests.cpp [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
TestFS.cpp [clangd] Ignore the static index refs from the dynamic index files. 2020-12-18 15:36:30 +03:00
TestFS.h [clangd] Fix crash-bug in preamble indexing when using modules. 2020-08-20 14:19:52 +02:00
TestIndex.cpp [clangd] NFC: Use SmallVector<T> where possible 2020-12-10 13:36:49 +01:00
TestIndex.h
…
TestScheme.h
…
TestTU.cpp Make iteration over the DeclContext::lookup_result safe. 2021-03-17 08:59:04 +00:00
TestTU.h [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
TestWorkspace.cpp [clangd] Add a TestWorkspace utility 2020-10-24 20:15:17 -04:00
TestWorkspace.h [clangd] Add a TestWorkspace utility 2020-10-24 20:15:17 -04:00
TidyProviderTests.cpp [clangd] Fix clang tidy provider when multiple config files exist in directory tree 2021-02-12 16:55:46 +00:00
TypeHierarchyTests.cpp [clangd] Introduce pullDiags endpoint 2021-03-16 12:52:15 +01:00
URITests.cpp [clangd] Fix conversion from Windows UNC paths to file URI format. 2020-07-22 12:13:09 +02:00
XRefsTests.cpp [clangd] ObjC fixes for semantic highlighting and xref highlights 2021-03-03 20:16:08 +01:00
lit.cfg.py
…
lit.site.cfg.py.in
…