Philip Reames 01801d5274 [rs4gc] Fix a latent bug around attribute stripping for intrinsics ... This change fixes a latent bug which was exposed by a change currently in review (https://reviews.llvm.org/D99802#2685032). The story on this is a bit involved. Without this change, what ended up happening with the pending review was that we'd strip attributes off intrinsics, and then selectiondag would fail to lower the intrinsic. Why? Because the lowering of the intrinsic relies on the presence of the readonly attribute. We don't have a matcher to select the case where there's a glue node needed. Now, on the surface, this still seems like a codegen bug. However, here it gets fun. I was unable to reproduce this with a standalone test at all, and was pretty much struck until skatkov provided the critical detail. This reproduces only when RS4GC and codegen are run in the same process and context. Why? Because it turns out we can't roundtrip the stripped attribute through serialized IR! We'll happily print out the missing attribute, but when we parse it back, the auto-upgrade logic has a side effect of blindly overwriting attributes on intrinsics with those specified in Intrinsics.td. This makes it impossible to exercise SelectionDAG from a standalone test case. At this point, I decided to treat this an RS4GC bug as a) we don't need to strip in this case, and b) I could write a test which shows the correct behavior to ensure this doesn't break again in the future. As an aside, I'd originally set out to handle libfuncs too - since in theory they might have the same issues - but backed away quickly when I realized how the semantics of builtin, nobuiltin, and no-builtin-x all interacted. I'm utterly convinced that no part of the optimizer handles that correctly, and decided not to open that can of worms here.		2021-04-19 13:14:07 -07:00
..
ADCE.cpp	Reapply "[DebugInfo] Handle multiple variable location operands in IR"	2021-03-17 16:45:25 +00:00
AlignmentFromAssumptions.cpp	[AssumeBundles] offset should be added to correctly calculate align	2021-04-02 12:32:05 +09:00
AnnotationRemarks.cpp	[AnnotationRemarks] Use subprogram location for summary remarks.	2021-03-23 12:05:41 +00:00
BDCE.cpp	…
CMakeLists.txt	[ScalarizeMaskedMemIntrinsic] Move from CodeGen into Transforms	2020-12-08 12:25:58 -05:00
CallSiteSplitting.cpp	[Support] Introduce a new InstructionCost class	2020-12-11 08:12:54 +00:00
ConstantHoisting.cpp	[ConstantHoisting] Fix bug where constant materialization could insert into EH pad	2021-02-01 11:23:56 -08:00
ConstraintElimination.cpp	[ConstraintElimination] Only strip casts preserving the representation.	2021-03-26 20:07:41 +00:00
CorrelatedValuePropagation.cpp	[CVP] processCallSite returns wrong status	2021-04-19 12:13:22 +07:00
DCE.cpp	[Scalar] Use range-based for loops (NFC)	2021-02-25 19:54:38 -08:00
DeadStoreElimination.cpp	[AA][NFC] Convert AliasResult to class containing offset for PartialAlias case.	2021-04-09 13:26:09 +03:00
DivRemPairs.cpp	[ValueTracking] Use assume's noundef operand bundle	2020-10-14 20:16:33 +09:00
EarlyCSE.cpp	Use AssumeInst in a few more places [nfc]	2021-04-06 13:18:53 -07:00
FlattenCFGPass.cpp	[NFC] Reduce include files dependency and AA header cleanup (part 2).	2020-12-17 14:04:48 +03:00
Float2Int.cpp	[NFC] Reduce include files dependency and AA header cleanup (part 2).	2020-12-17 14:04:48 +03:00
GVN.cpp	[NFC] Move statictic increment out of helper	2021-04-09 16:32:35 +07:00
GVNHoist.cpp	Require chained analyses in BasicAA and AAResults to be transitive	2021-01-11 11:50:07 +01:00
GVNSink.cpp	[Transforms] Use llvm::append_range (NFC)	2021-01-20 21:35:54 -08:00
GuardWidening.cpp	[llvm] Use llvm::all_of (NFC)	2021-01-19 20:19:17 -08:00
IVUsersPrinter.cpp	…
IndVarSimplify.cpp	[indvars[ Fix pr49802 by checking for SCEVCouldNotCompute	2021-04-01 17:53:44 -07:00
InductiveRangeCheckElimination.cpp	[NFC][NewPM] Remove some AnalysisManager invalidate methods	2021-04-15 16:51:26 -07:00
InferAddressSpaces.cpp	[NewPM] Port infer-address-spaces	2020-12-28 19:58:12 -08:00
InstSimplifyPass.cpp	[Bindings] Move LLVMAddInstructionSimplifyPass to Scalar.cpp	2020-09-02 10:35:39 -07:00
JumpThreading.cpp	[JumpThreading] merge debug info when merging select+br	2021-04-12 17:51:21 -07:00
LICM.cpp	[LICM] Make capture check more precise	2021-04-19 20:34:23 +02:00
LoopAccessAnalysisPrinter.cpp	…
LoopDataPrefetch.cpp	[LoopInfo] empty() -> isInnermost(), add isOutermost()	2020-09-22 23:28:51 +03:00
LoopDeletion.cpp	[LoopDeletion] Handle inner loops w/untaken backedges	2021-01-22 16:31:29 -08:00
LoopDistribute.cpp	[NFC] Reduce include files dependency and AA header cleanup (part 2).	2020-12-17 14:04:48 +03:00
LoopFlatten.cpp	LoopFlatten - CanWidenIV - Fix uninitialized variable warnings and use for-range loop. NFCI.	2021-04-06 12:24:20 +01:00
LoopFuse.cpp	[LoopFusion] Bails out if only the second candidate is guarded (PR48060)	2021-04-06 01:08:56 +08:00
LoopIdiomRecognize.cpp	[LoopIdiom] left-shift-until-bittest: set all allowed no-wrap flags on add/sub	2021-04-11 18:08:07 +03:00
LoopInstSimplify.cpp	…
LoopInterchange.cpp	[LoopInterchange] Fix transformation bugs in loop interchange	2021-04-08 14:58:13 -04:00
LoopLoadElimination.cpp	[LoopLoadElim] Pass ScalarEvolution in old pass manager. PR49141	2021-02-15 18:08:23 +07:00
LoopPassManager.cpp	[NewPM] Verify LoopAnalysisResults after a loop pass	2021-03-19 14:56:37 -07:00
LoopPredication.cpp	[BPI] Improve static heuristics for "cold" paths.	2020-12-23 22:47:36 +07:00
LoopRerollPass.cpp	[Scalar] Use range-based for loops (NFC)	2021-02-25 19:54:38 -08:00
LoopRotation.cpp	[LoopRotate] Don't split loop pass manager	2021-04-08 22:05:18 +02:00
LoopSimplifyCFG.cpp	[DominatorTree] Add support for mixed pre/post CFG views.	2021-01-06 14:53:09 -08:00
LoopSink.cpp	[llvm] Use set_is_subset (NFC)	2021-02-28 10:59:20 -08:00
LoopStrengthReduce.cpp	[LSR] Fix for pre-indexed generated constant offset	2021-04-15 16:44:42 +01:00
LoopUnrollAndJamPass.cpp	[LoopUnrollAndJam] Allow unroll and jam loops forced by user.	2020-09-17 19:40:14 +00:00
LoopUnrollPass.cpp	NFC: Migrate LoopUnrollPass to work on InstructionCost	2021-02-04 14:05:40 +00:00
LoopUnswitch.cpp	Add a subclass of IntrinsicInst for llvm.assume [nfc]	2021-04-06 11:16:22 -07:00
LoopVersioningLICM.cpp	[SCEV] Use isa<> pattern for testing for CouldNotCompute [NFC]	2020-11-24 18:47:49 -08:00
LowerAtomic.cpp	…
LowerConstantIntrinsics.cpp	[LowerConstantIntrinsics] Preserve Dominator Tree, if avaliable	2021-01-30 01:14:50 +03:00
LowerExpectIntrinsic.cpp	[TargetTransformInfo] move branch probability query from TargetLoweringInfo	2021-03-22 15:55:34 -04:00
LowerGuardIntrinsic.cpp	…
LowerMatrixIntrinsics.cpp	[NFC][AA] Prepare to convert AliasResult to class with PartialAlias offset.	2021-04-09 12:54:22 +03:00
LowerWidenableCondition.cpp	…
MakeGuardsExplicit.cpp	…
MemCpyOptimizer.cpp	[MemCpyOpt] Add missing MemorySSAWrapperPass dependency macro	2021-03-16 20:30:00 +01:00
MergeICmps.cpp	[Transforms/Scalar] Use range-based for loops (NFC)	2021-02-04 21:18:05 -08:00
MergedLoadStoreMotion.cpp	…
NaryReassociate.cpp	[NARY][NFC] Use hasNUsesOrMore instead of getNumUses since it's more	2021-04-13 09:29:49 +07:00
NewGVN.cpp	[NewGVN] Add phi-of-ops operands if no real PHI is created.	2021-04-15 08:25:10 +01:00
PartiallyInlineLibCalls.cpp	[PartiallyInlineLibCalls] Preserve Dominator Tree, if avaliable	2021-01-29 01:11:36 +03:00
PlaceSafepoints.cpp	[Transforms] Use llvm::append_range (NFC)	2020-12-27 09:57:29 -08:00
Reassociate.cpp	[Reassociate] allow or->add with shl operands	2021-02-07 09:45:19 -05:00
Reg2Mem.cpp	[Reg2Mem] add support for the new pass manager	2020-11-08 11:14:05 +00:00
RewriteStatepointsForGC.cpp	[rs4gc] Fix a latent bug around attribute stripping for intrinsics	2021-04-19 13:14:07 -07:00
SCCP.cpp	[SCCP] Follow up of rGbbab9f986c6d. NFC.	2021-04-14 17:14:46 +01:00
SROA.cpp	[SROA] Allow SROA on pointers with invariant group intrinsic uses	2021-04-05 19:53:40 -07:00
Scalar.cpp	[ScalarizeMaskedMemIntrin] Add new PM support	2020-12-08 17:15:22 -05:00
ScalarizeMaskedMemIntrin.cpp	Expand masked mem intrinsics correctly wrt big-endian	2021-02-11 08:59:52 +00:00
Scalarizer.cpp	[Scalarizer] Use poison as insertelement's placeholder	2021-01-04 00:35:28 +09:00
SeparateConstOffsetFromGEP.cpp	SeparateConstOffsetFromGEP::lowerToSingleIndexGEPs - don't use dyn_cast_or_null. NFCI.	2020-12-15 17:27:25 +00:00
SimpleLoopUnswitch.cpp	Add a subclass of IntrinsicInst for llvm.assume [nfc]	2021-04-06 11:16:22 -07:00
SimplifyCFGPass.cpp	[NFCI][SimplifyCFG] mergeEmptyReturnBlocks(): improve Dominator Tree updating	2021-04-11 23:56:23 +03:00
Sink.cpp	Sink: Handle instruction sink when a user is dead	2020-10-09 16:20:26 -07:00
SpeculateAroundPHIs.cpp	NFC: Migrate SpeculateAroundPHIs to work on InstructionCost	2021-02-02 13:32:45 +00:00
SpeculativeExecution.cpp	Reapply "[DebugInfo] Handle multiple variable location operands in IR"	2021-03-17 16:45:25 +00:00
StraightLineStrengthReduce.cpp	[Transforms/Scalar] Use range-based for loops (NFC)	2021-02-04 21:18:05 -08:00
StructurizeCFG.cpp	[Scalar] Use range-based for loops (NFC)	2021-02-25 19:54:38 -08:00
TailRecursionElimination.cpp	Normalize interaction with boolean attributes	2021-04-17 08:17:33 +02:00
WarnMissedTransforms.cpp	[SVE] Add support for scalable vectors with vectorize.scalable.enable loop attribute	2020-12-02 13:23:43 +00:00