Aleksandr Platonov 555eacf75f [clangd] Fix undefined behavior when generating error message at rename with an invalid name ... `Message()` lambda uses `Reason.Details` as an input parameter for `llvm::formatv()`, but `Reason` in `Message()` is a local object. Return value of `llvm::formatv()` contains references to its input arguments, thus `Message()` returns an object which contains a reference to `Details` field of the local object `Reason`. This patch fixes this behavior by passing `Reason` as a reference to `Message()` to ensure that return value of `Message()` contains references to alive object and also prevents copying of `InvalidName` structure at passing it to `makeError()`. Provided test passes on Linux+GCC with or without this patch, but fails on Windows+VisualStudio without this patch. Reviewed By: sammccall Differential Revision: https://reviews.llvm.org/D115959		2021-12-19 22:28:26 +03:00
..
tweaks	[NFC][clangd] cleanup llvm-else-after-return findings	2021-11-17 14:37:03 +00:00
Rename.cpp	[clangd] Fix undefined behavior when generating error message at rename with an invalid name	2021-12-19 22:28:26 +03:00
Rename.h	[clangd] Use Dirty Filesystem for cross file rename.	2021-03-10 13:41:29 +00:00
Tweak.cpp	[clangd] Use dirty filesystem when performing cross file tweaks	2021-04-20 17:13:44 +01:00
Tweak.h	[clangd] cleanup of header guard names	2021-12-02 15:58:35 +00:00