Keith Smiley 4c12a75e69 [llvm-libtool-darwin] Add -warnings_as_errors ... libtool can currently produce 2 warnings: 1. No symbols were in the object file 2. An object file with the same basename was specified multiple times The first warning here is often harmless and may just mean you have some translation units with no symbols for the target you're building for. The second warning can lead to real issues like those mentioned in https://reviews.llvm.org/D113130 where ODR violations can slip in. This introduces a new -warnings_as_errors flag that can be used by build systems that want to verify they never hit these warnings. For example with bazel the libtool caller first uniques names to make sure the duplicate base name case is not possible, but if that doesn't work as expected, having it fail would be preferred. It's also worth noting that llvm-libtool-darwin works around an issue that cctools libtool experiences related to debug info and duplicate basenames, the workaround is described here: 30baa5d2a4/llvm/lib/Object/ArchiveWriter.cpp (L424-L465) And it avoids this bug: f0cbbb1c37/DuplicateBasenameIssue Differential Revision: https://reviews.llvm.org/D118931		2022-02-07 14:39:21 -08:00
..
CMakeLists.txt	[llvm-libtool-darwin] Fix crash with bitcode asm module	2022-02-04 10:54:27 -08:00
llvm-libtool-darwin.cpp	[llvm-libtool-darwin] Add -warnings_as_errors	2022-02-07 14:39:21 -08:00