14735cab65
Modify OpenOptions enum to open the future path into synchronizing vFile:open bits with GDB. Currently, LLDB and GDB use different flag models effectively making it impossible to match bits. Notably, LLDB uses two bits to indicate read and write status, and uses union of both for read/write. GDB uses a value of 0 for read-only, 1 for write-only and 2 for read/write. In order to future-proof the code for the GDB variant: 1. Add a distinct eOpenOptionReadWrite constant to be used instead of (eOpenOptionRead | eOpenOptionWrite) when R/W access is required. 2. Rename eOpenOptionRead and eOpenOptionWrite to eOpenOptionReadOnly and eOpenOptionWriteOnly respectively, to make it clear that they do not mean to be combined and require update to all call sites. 3. Use the intersection of all three flags when matching against the three possible values. This commit does not change the actual bits used by LLDB. Differential Revision: https://reviews.llvm.org/D106984 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| RenderScriptExpressionOpts.cpp | ||
| RenderScriptExpressionOpts.h | ||
| RenderScriptRuntime.cpp | ||
| RenderScriptRuntime.h | ||
| RenderScriptScriptGroup.cpp | ||
| RenderScriptScriptGroup.h | ||
| RenderScriptx86ABIFixups.cpp | ||
| RenderScriptx86ABIFixups.h | ||