llvm-project/llvm/lib/Target/SystemZ
Jonas Paulsson 370a8c8025 [SystemZ] Make sure not to call getZExtValue on a >64 bit constant.
Better use isZero() and isIntN() in SystemZTargetTransformInfo rather than
calling getZExtValue() since the immediate operand may be wider than 64 bits,
which is not allowed with getZExtValue().

Fixes https://bugs.llvm.org/show_bug.cgi?id=47600

Review: Simon Pilgrim
2020-09-23 15:36:32 +02:00
..
AsmParser [SystemZ] Allow specifying integer registers as part of the address calculation 2020-07-08 18:20:24 +02:00
Disassembler
MCTargetDesc [X86][MC][Target] Initial backend support a tune CPU to support -mtune 2020-08-14 15:31:50 -07:00
TargetInfo
CMakeLists.txt
LLVMBuild.txt
README.txt
SystemZ.h
SystemZ.td
SystemZAsmPrinter.cpp
SystemZAsmPrinter.h
SystemZCallingConv.cpp
SystemZCallingConv.h [Alignment][NFC] Migrate the rest of backends 2020-06-08 07:17:20 +00:00
SystemZCallingConv.td
SystemZConstantPoolValue.cpp [CodeGen] Use Align in MachineConstantPool. 2020-05-12 10:06:40 -07:00
SystemZConstantPoolValue.h [CodeGen] Use Align in MachineConstantPool. 2020-05-12 10:06:40 -07:00
SystemZCopyPhysRegs.cpp
SystemZElimCompare.cpp
SystemZFeatures.td [NFC] Fix typo in comment. 2020-08-11 05:27:56 -04:00
SystemZFrameLowering.cpp [Alignment][NFC] Migrate MachineFrameInfo::CreateStackObject to Align 2020-07-01 07:28:11 +00:00
SystemZFrameLowering.h [SystemZ] Implement -fstack-clash-protection 2020-06-06 18:38:36 +02:00
SystemZHazardRecognizer.cpp
SystemZHazardRecognizer.h
SystemZISelDAGToDAG.cpp [SystemZ] Bugfix in storeLoadCanUseBlockBinary(). 2020-06-17 09:49:31 +02:00
SystemZISelLowering.cpp [SystemZ] Preserve the MachineMemOperand in emitCondStore() in all cases. 2020-08-24 14:07:30 +02:00
SystemZISelLowering.h [SystemZ] Improve handling of ZERO_EXTEND_VECTOR_INREG. 2020-06-30 09:08:10 +02:00
SystemZInstrBuilder.h SystemZInstrBuilder.h - remove unnecessary PseudoSourceValue.h include. NFC. 2020-05-25 12:41:22 +01:00
SystemZInstrDFP.td
SystemZInstrFP.td [SystemZ] Improve foldMemoryOperandImpl: vec->FP conversions 2020-05-12 09:21:24 +02:00
SystemZInstrFormats.td [SystemZ] Improve foldMemoryOperandImpl: vec->FP conversions 2020-05-12 09:21:24 +02:00
SystemZInstrHFP.td
SystemZInstrInfo.cpp [SystemZ] Implement -fstack-clash-protection 2020-06-06 18:38:36 +02:00
SystemZInstrInfo.h [SystemZ] Implement -fstack-clash-protection 2020-06-06 18:38:36 +02:00
SystemZInstrInfo.td [SystemZ] Implement -fstack-clash-protection 2020-06-06 18:38:36 +02:00
SystemZInstrSystem.td
SystemZInstrVector.td [SystemZ] Improve foldMemoryOperandImpl: vec->FP conversions 2020-05-12 09:21:24 +02:00
SystemZLDCleanup.cpp
SystemZLongBranch.cpp
SystemZMCInstLower.cpp
SystemZMCInstLower.h
SystemZMachineFunctionInfo.cpp
SystemZMachineFunctionInfo.h CodeGen: Use Register 2020-05-19 17:56:55 -04:00
SystemZMachineScheduler.cpp
SystemZMachineScheduler.h
SystemZOperands.td [TableGen] Drop deprecated leading # operation (NOP) and replace ## with # 2020-04-25 16:26:45 -07:00
SystemZOperators.td [SystemZ] Implement -fstack-clash-protection 2020-06-06 18:38:36 +02:00
SystemZPatterns.td [TableGen] Drop deprecated leading # operation (NOP) and replace ## with # 2020-04-25 16:26:45 -07:00
SystemZPostRewrite.cpp
SystemZProcessors.td [llvm] NFC: Fix trivial typo in rst and td files 2020-04-23 14:26:32 +09:00
SystemZRegisterInfo.cpp [DebugInfo] Update MachineInstr to help support variadic DBG_VALUE instructions 2020-06-22 16:01:12 +01:00
SystemZRegisterInfo.h
SystemZRegisterInfo.td [TableGen] Drop deprecated leading # operation (NOP) and replace ## with # 2020-04-25 16:26:45 -07:00
SystemZSchedule.td
SystemZScheduleZ13.td
SystemZScheduleZ14.td
SystemZScheduleZ15.td
SystemZScheduleZ196.td
SystemZScheduleZEC12.td
SystemZSelectionDAGInfo.cpp [SelectionDAG] Use Align/MaybeAlign in calls to getLoad/getStore/getExtLoad/getTruncStore. 2020-09-14 13:54:50 -07:00
SystemZSelectionDAGInfo.h [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemcpy to Align 2020-06-30 13:12:31 +00:00
SystemZShortenInst.cpp
SystemZSubtarget.cpp [X86][MC][Target] Initial backend support a tune CPU to support -mtune 2020-08-14 15:31:50 -07:00
SystemZSubtarget.h [X86][MC][Target] Initial backend support a tune CPU to support -mtune 2020-08-14 15:31:50 -07:00
SystemZTDC.cpp TargetLowering.h - remove unnecessary TargetMachine.h include. NFC 2020-05-23 19:49:38 +01:00
SystemZTargetMachine.cpp [Attributes] Add a method to check if an Attribute has AttrKind None. Use instead of hasAttribute(Attribute::None) 2020-08-28 13:23:45 -07:00
SystemZTargetMachine.h
SystemZTargetTransformInfo.cpp [SystemZ] Make sure not to call getZExtValue on a >64 bit constant. 2020-09-23 15:36:32 +02:00
SystemZTargetTransformInfo.h [ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being hoisted when in a loop 2020-09-22 11:54:10 +00:00

README.txt

//===---------------------------------------------------------------------===//
// Random notes about and ideas for the SystemZ backend.
//===---------------------------------------------------------------------===//

The initial backend is deliberately restricted to z10.  We should add support
for later architectures at some point.

--

If an inline asm ties an i32 "r" result to an i64 input, the input
will be treated as an i32, leaving the upper bits uninitialised.
For example:

define void @f4(i32 *%dst) {
  %val = call i32 asm "blah $0", "=r,0" (i64 103)
  store i32 %val, i32 *%dst
  ret void
}

from CodeGen/SystemZ/asm-09.ll will use LHI rather than LGHI.
to load 103.  This seems to be a general target-independent problem.

--

The tuning of the choice between LOAD ADDRESS (LA) and addition in
SystemZISelDAGToDAG.cpp is suspect.  It should be tweaked based on
performance measurements.

--

There is no scheduling support.

--

We don't use the BRANCH ON INDEX instructions.

--

We only use MVC, XC and CLC for constant-length block operations.
We could extend them to variable-length operations too,
using EXECUTE RELATIVE LONG.

MVCIN, MVCLE and CLCLE may be worthwhile too.

--

We don't use CUSE or the TRANSLATE family of instructions for string
operations.  The TRANSLATE ones are probably more difficult to exploit.

--

We don't take full advantage of builtins like fabsl because the calling
conventions require f128s to be returned by invisible reference.

--

ADD LOGICAL WITH SIGNED IMMEDIATE could be useful when we need to
produce a carry.  SUBTRACT LOGICAL IMMEDIATE could be useful when we
need to produce a borrow.  (Note that there are no memory forms of
ADD LOGICAL WITH CARRY and SUBTRACT LOGICAL WITH BORROW, so the high
part of 128-bit memory operations would probably need to be done
via a register.)

--

We don't use ICM, STCM, or CLM.

--

We don't use ADD (LOGICAL) HIGH, SUBTRACT (LOGICAL) HIGH,
or COMPARE (LOGICAL) HIGH yet.

--

DAGCombiner doesn't yet fold truncations of extended loads.  Functions like:

    unsigned long f (unsigned long x, unsigned short *y)
    {
      return (x << 32) | *y;
    }

therefore end up as:

        sllg    %r2, %r2, 32
        llgh    %r0, 0(%r3)
        lr      %r2, %r0
        br      %r14

but truncating the load would give:

        sllg    %r2, %r2, 32
        lh      %r2, 0(%r3)
        br      %r14

--

Functions like:

define i64 @f1(i64 %a) {
  %and = and i64 %a, 1
  ret i64 %and
}

ought to be implemented as:

        lhi     %r0, 1
        ngr     %r2, %r0
        br      %r14

but two-address optimizations reverse the order of the AND and force:

        lhi     %r0, 1
        ngr     %r0, %r2
        lgr     %r2, %r0
        br      %r14

CodeGen/SystemZ/and-04.ll has several examples of this.

--

Out-of-range displacements are usually handled by loading the full
address into a register.  In many cases it would be better to create
an anchor point instead.  E.g. for:

define void @f4a(i128 *%aptr, i64 %base) {
  %addr = add i64 %base, 524288
  %bptr = inttoptr i64 %addr to i128 *
  %a = load volatile i128 *%aptr
  %b = load i128 *%bptr
  %add = add i128 %a, %b
  store i128 %add, i128 *%aptr
  ret void
}

(from CodeGen/SystemZ/int-add-08.ll) we load %base+524288 and %base+524296
into separate registers, rather than using %base+524288 as a base for both.

--

Dynamic stack allocations round the size to 8 bytes and then allocate
that rounded amount.  It would be simpler to subtract the unrounded
size from the copy of the stack pointer and then align the result.
See CodeGen/SystemZ/alloca-01.ll for an example.

--

If needed, we can support 16-byte atomics using LPQ, STPQ and CSDG.

--

We might want to model all access registers and use them to spill
32-bit values.

--

We might want to use the 'overflow' condition of eg. AR to support
llvm.sadd.with.overflow.i32 and related instructions - the generated code
for signed overflow check is currently quite bad.  This would improve
the results of using -ftrapv.