RT-Thread
/
rt-thread
mirror of https://github.com/RT-Thread/rt-thread
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[Fix] <components>:finsh/shell.c F: char rt_hw_console_getchar(void) (#10345) 

[Fix] <components>:finsh/shell.c
When using char rt_hw_console_getchar(void),
some compilers may default to returning 255 instead of the expected -1,
causing the condition if(ch < 0) at F: shell.c L:519 to fail and enter an erroneous loop.

Solution: Use the signed char type return value as rt_hw_console_getchar

Signed-off-by: Yucai Liu <1486344514@qq.com>
This commit is contained in:
ricky 2025-07-20 17:35:35 +08:00 committed by GitHub
parent ece19e961a
commit 9c5aeb75e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
components/finsh/shell.c
View File

@ -193,7 +193,7 @@ int finsh_getchar(void)
return ch;
#endif /* RT_USING_POSIX_STDIO */
#else
extern char rt_hw_console_getchar(void);
extern signed char rt_hw_console_getchar(void);
return rt_hw_console_getchar();
#endif /* RT_USING_DEVICE */
}