From 22d8045ce59e4666fc9dcad68c07ecc0071ff4b6 Mon Sep 17 00:00:00 2001
From: Emily Soth <esoth@stanford.edu>
Date: Wed, 28 May 2025 14:16:11 -0700
Subject: [PATCH] shut down plugin process before removing its environment

---
 workbench/src/main/setupAddRemovePlugin.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/workbench/src/main/setupAddRemovePlugin.js b/workbench/src/main/setupAddRemovePlugin.js
index 0c9dedaf4..31b386298 100644
--- a/workbench/src/main/setupAddRemovePlugin.js
+++ b/workbench/src/main/setupAddRemovePlugin.js
@@ -11,6 +11,7 @@ import crypto from 'crypto';
 import { getLogger } from './logger';
 import { ipcMainChannels } from './ipcMainChannels';
 import { settingsStore } from './settingsStore';
+import { shutdownPythonProcess } from './createPythonFlaskProcess';
 
 const logger = getLogger(__filename.split('/').slice(-1)[0]);
 
@@ -190,6 +191,9 @@ export function setupRemovePlugin() {
     async (e, pluginID) => {
       logger.info('removing plugin', pluginID);
       try {
+        // Shut down the plugin server process
+        const pluginPID = settingsStore.get(`plugins.${pluginID}.pid`);
+        await shutdownPythonProcess(pluginPID);
         // Delete the plugin's conda env
         const env = settingsStore.get(`plugins.${pluginID}.env`);
         const micromamba = settingsStore.get('micromamba');