Return good exit status on --help.

bin/verilator

@@ -115,7 +115,7 @@ if ($opt_gdb) {
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
 }
 
 sub debug {

bin/verilator_coverage

@@ -66,7 +66,7 @@ run(verilator_coverage_bin()
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
 }
 
 sub debug {

bin/verilator_difftree

@@ -168,8 +168,8 @@ sub filter {
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub debug {

bin/verilator_gantt

@@ -43,8 +43,8 @@ exit(0);
 #######################################################################
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub parameter {

bin/verilator_profcfunc

@@ -39,8 +39,8 @@ profcfunc($Opt_File);
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub debug {

nodist/dot_importer

@@ -38,8 +38,8 @@ cwrite("graph_export.cpp");
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub debug {

nodist/dot_pruner

@@ -43,8 +43,8 @@ dotwrite();
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub debug {

nodist/git_untabify

@@ -22,7 +22,8 @@ Getopt::Long::config("no_auto_abbrev");
 if (! GetOptions (
           "debug"       => sub { $Debug = 1; },
           "help"        => sub { print "Version $VERSION\n";
-                                 pod2usage(-verbose=>2, -exitval => 2, output=>\*STDOUT, -noperldoc=>1); },
+                                 pod2usage(-verbose=>2, -exitval => 0,
+                                           output=>\*STDOUT, -noperldoc=>1); },
           "narrow!"     => sub { $Opt_Widen = 0; },
           "version"     => sub { print "Version $VERSION\n"; exit(0); },
           "widen!"      => sub { $Opt_Widen = 1; },  # Default, undocumented

nodist/vtree_importer

@@ -40,8 +40,8 @@ print '(query-replace-regexp "(\\([0-9a-z_]+\\))" "\\1" nil nil nil)',"\n";
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub debug {

src/astgen

@@ -50,8 +50,8 @@ foreach my $cpt (@Opt_Cpt) {
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub parameter {

src/bisonpre

@@ -56,8 +56,8 @@ process();
 
 sub usage {
     print "Version $VERSION\n";
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT, -noperldoc=>1);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT, -noperldoc=>1);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub parameter {

src/cppcheck_filtered

@@ -39,8 +39,8 @@ process();
 
 sub usage {
     print "Version $VERSION\n";
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT, -noperldoc=>1);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT, -noperldoc=>1);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 #######################################################################

src/vlcovgen

@@ -33,8 +33,8 @@ write_keys("$Opt_Srcdir/../include/verilated_cov_key.h");
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 #######################################################################

test_regress/driver.pl

@@ -201,8 +201,8 @@ exit(10) if $runner->fail_count;
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub debug {

test_regress/t/t_flag_help.pl

@@ -17,7 +17,7 @@ foreach my $prog (
     "../bin/verilator_gantt",
     "../bin/verilator_profcfunc",
     ) {
-    run(fails => 1,
+    run(fails => 0,
         cmd => ["perl", $prog,
                 "--help"],
         logfile => "$Self->{obj_dir}/t_help.log",

test_regress/vgen.pl

@@ -237,8 +237,8 @@ write_output_v($Opt_Output);
 #----------------------------------------------------------------------
 
 sub usage {
-    pod2usage(-verbose=>2, -exitval=>2, -output=>\*STDOUT);
+    pod2usage(-verbose=>2, -exitval=>0, -output=>\*STDOUT);
-    exit(1);
+    exit(1);  # Unreachable
 }
 
 sub debug {