VeniVidiVici
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change unsupported 'tagged' into parse-level message

This commit is contained in:
Wilson Snyder 2025-04-30 18:30:19 -04:00
parent 0664cf407c
commit b10b22d09f
4 changed files with 47 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/verilog.l
View File

@ -581,7 +581,7 @@ vnum {vnum1}|{vnum2}|{vnum3}|{vnum4}|{vnum5}
"string" { FL; return ySTRING; }
"struct" { FL; return ySTRUCT; }
"super" { FL; return ySUPER; }
"tagged" { ERROR_RSVD_WORD("SystemVerilog 2005"); }
"tagged" { FL; return yTAGGED; }
"this" { FL; return yTHIS; }
"throughout" { FL; return yTHROUGHOUT; }
"timeprecision" { FL; return yTIMEPRECISION; }

15
src/verilog.y
View File

@ -749,7 +749,7 @@ BISONPRE_VERSION(3.7,%define api.header.include {"V3ParseBison.h"})
%token<fl> yS_UNTIL "s_until"
%token<fl> yS_UNTIL_WITH "s_until_with"
%token<fl> yTABLE "table"
//UNSUP %token<fl> yTAGGED "tagged"
%token<fl> yTAGGED "tagged"
%token<fl> yTASK "task"
%token<fl> yTHIS "this"
%token<fl> yTHROUGHOUT "throughout"
@ -1080,7 +1080,7 @@ BISONPRE_VERSION(3.7,%define api.header.include {"V3ParseBison.h"})
// These prevent other conflicts
%left yP_ANDANDAND
%left yMATCHES
//UNSUP %left prTAGGED
%left prTAGGED
//UNSUP %left prSEQ_CLOCKING
// PSL op precedence
@ -2447,7 +2447,7 @@ random_qualifier<qualifiers>: // ==IEEE: random_qualifier
taggedSoftE<cbool>:
/*empty*/ { $$ = false; }
| ySOFT { $$ = true; }
//UNSUP yTAGGED { UNSUP }
| yTAGGED { $$ = false; BBUNSUP($<fl>1, "Unsupported: tagged union"); }
;
packedSigningE<signstate>:
@ -4033,8 +4033,8 @@ patternNoExpr<nodep>: // IEEE: pattern **Excluding Expr*
{ $$ = nullptr; BBUNSUP($1, "Unsupported: '{} tagged patterns"); }
// // IEEE: "expr" excluded; expand in callers
// // "yTAGGED idAny [expr]" Already part of expr
//UNSUP yTAGGED idAny/*member_identifier*/ patternNoExpr
//UNSUP { $$ = nullptr; BBUNSUP($1, "Unsupported: '{} tagged patterns"); }
| yTAGGED idAny/*member_identifier*/ patternNoExpr
{ $$ = nullptr; BBUNSUP($1, "Unsupported: '{} tagged patterns"); }
// // "yP_TICKBRA patternList '}'" part of expr under assignment_pattern
;
@ -5083,8 +5083,9 @@ expr<nodeExprp>: // IEEE: part of expression/constant_expression/
| ~l~expr yINSIDE '{' range_list '}' { $$ = new AstInside{$2, $1, $4}; }
//
// // IEEE: tagged_union_expression
//UNSUP yTAGGED id/*member*/ %prec prTAGGED { UNSUP }
//UNSUP yTAGGED id/*member*/ %prec prTAGGED primary { UNSUP }
//UNSUP yTAGGED id/*member*/ %prec prTAGGED { $$ = $2; BBUNSUP("tagged reference"); }
// // Spec only allows primary
//UNSUP yTAGGED id/*member*/ %prec prTAGGED expr /*primary*/ { $$ = $2; BBUNSUP("tagged reference"); }
//
//======================// IEEE: primary/constant_primary
//

70
test_regress/t/t_tagged.out
View File

@ -1,56 +1,42 @@
%Error-UNSUPPORTED: t/t_tagged.v:9:18: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
%Error-UNSUPPORTED: t/t_tagged.v:9:18: Unsupported: tagged union
9 | typedef union tagged {
| ^~~~~~
... For error description see https://verilator.org/warn/UNSUPPORTED?v=latest
%Error-UNSUPPORTED: t/t_tagged.v:10:6: Unsupported: void (for tagged unions)
10 | void m_invalid;
| ^~~~
%Error-UNSUPPORTED: t/t_tagged.v:18:11: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
18 | u = tagged m_invalid;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:22:9: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
22 | tagged m_invalid: ;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:23:9: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
23 | tagged m_int: $stop;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:21:16: Unsupported: matches (for tagged union)
21 | case (u) matches
%Error: t/t_tagged.v:19:14: syntax error, unexpected tagged, expecting IDENTIFIER-for-type
19 | u = tagged m_invalid;
| ^~~~~~
... See the manual at https://verilator.org/verilator_doc.html?v=latest for more assistance.
%Error-UNSUPPORTED: t/t_tagged.v:24:16: Unsupported: matches (for tagged union)
24 | case (u) matches
| ^~~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:26:21: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
26 | if (u matches tagged m_invalid) ;
%Error: t/t_tagged.v:29:9: syntax error, unexpected tagged, expecting IDENTIFIER-for-type
29 | tagged m_invalid: ;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:34:34: Unsupported: '{} tagged patterns
34 | if (u matches tagged m_int .n) $stop;
| ^
%Error-UNSUPPORTED: t/t_tagged.v:34:21: Unsupported: '{} tagged patterns
34 | if (u matches tagged m_int .n) $stop;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:26:13: Unsupported: matches operator
26 | if (u matches tagged m_invalid) ;
%Error-UNSUPPORTED: t/t_tagged.v:34:13: Unsupported: matches operator
34 | if (u matches tagged m_int .n) $stop;
| ^~~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:27:21: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
27 | if (u matches tagged m_int .n) $stop;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:27:13: Unsupported: matches operator
27 | if (u matches tagged m_int .n) $stop;
| ^~~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:29:11: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
29 | u = tagged m_int (123);
%Error: t/t_tagged.v:36:11: syntax error, unexpected tagged, expecting IDENTIFIER-for-type
36 | u = tagged m_int (123);
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:33:9: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
33 | tagged m_invalid: $stop;
%Error: t/t_tagged.v:40:9: syntax error, unexpected tagged, expecting IDENTIFIER-for-type
40 | tagged m_invalid: $stop;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:34:9: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
34 | tagged m_int .n: if (n !== 123) $stop;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:32:16: Unsupported: matches (for tagged union)
32 | case (u) matches
| ^~~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:37:21: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
37 | if (u matches tagged m_invalid) $stop;
%Error-UNSUPPORTED: t/t_tagged.v:45:34: Unsupported: '{} tagged patterns
45 | if (u matches tagged m_int .n) if (n != 123) $stop;
| ^
%Error-UNSUPPORTED: t/t_tagged.v:45:21: Unsupported: '{} tagged patterns
45 | if (u matches tagged m_int .n) if (n != 123) $stop;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:37:13: Unsupported: matches operator
37 | if (u matches tagged m_invalid) $stop;
| ^~~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:38:21: Unsupported: SystemVerilog 2005 reserved word not implemented: 'tagged'
38 | if (u matches tagged m_int .n) if (n != 123) $stop;
| ^~~~~~
%Error-UNSUPPORTED: t/t_tagged.v:38:13: Unsupported: matches operator
38 | if (u matches tagged m_int .n) if (n != 123) $stop;
%Error-UNSUPPORTED: t/t_tagged.v:45:13: Unsupported: matches operator
45 | if (u matches tagged m_int .n) if (n != 123) $stop;
| ^~~~~~~
%Error: Exiting due to

13
test_regress/t/t_tagged.v
View File

@ -15,9 +15,16 @@ module t(/*AUTOARG*/);
string s;
initial begin
u = tagged m_invalid;
s = $sformatf("%p", u);
$display("%s e.g. '{tagged m_invalid:void}", s);
begin
u = tagged m_invalid;
s = $sformatf("%p", u);
$display("%s e.g. '{tagged m_invalid:void}", s);
end
case (u) matches
default: ;
endcase
case (u) matches
tagged m_invalid: ;
tagged m_int: $stop;