VeniVidiVici
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

review

This commit is contained in:
Geza Lore 2025-07-21 13:46:07 +01:00
parent 2eae6d0c62
commit f2ee1e9bd5
2 changed files with 9 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/V3Dfg.cpp
View File

@ -239,20 +239,6 @@ DfgVertexVar* DfgGraph::makeNewVar(FileLine* flp, const std::string& name, AstNo
static const string toDotId(const DfgVertex& vtx) { return '"' + cvtToHex(&vtx) + '"'; }
static void dumpType(std::ostream& os, const AstNodeDType* dtypep) {
if (const AstUnpackArrayDType* const typep = VN_CAST(dtypep, UnpackArrayDType)) {
os << '(';
dumpType(os, typep->subDTypep());
os << ")[" << typep->elementsConst() << ']';
return;
}
if (const AstBasicDType* const typep = VN_CAST(dtypep, BasicDType)) {
os << "W" << typep->width();
return;
}
dtypep->v3fatalSrc("Unahndled AstNodeDType sub-type");
}
// Dump one DfgVertex in Graphviz format
static void dumpDotVertex(std::ostream& os, const DfgVertex& vtx) {
@ -261,7 +247,7 @@ static void dumpDotVertex(std::ostream& os, const DfgVertex& vtx) {
AstVar* const varp = varVtxp->varp();
os << toDotId(vtx);
os << " [label=\"" << nodep->name() << "\n";
dumpType(os, varVtxp->dtypep());
varVtxp->dtypep()->dumpSmall(os);
os << " / F" << varVtxp->fanout() << '"';
if (varp->direction() == VDirection::INPUT) {
@ -290,7 +276,7 @@ static void dumpDotVertex(std::ostream& os, const DfgVertex& vtx) {
AstVar* const varp = arrVtxp->varp();
os << toDotId(vtx);
os << " [label=\"" << nodep->name() << "\n";
dumpType(os, arrVtxp->dtypep());
arrVtxp->dtypep()->dumpSmall(os);
os << " / F" << arrVtxp->fanout() << '"';
if (varp->direction() == VDirection::INPUT) {
os << ", shape=box3d, style=filled, fillcolor=chartreuse2"; // Green
@ -335,7 +321,7 @@ static void dumpDotVertex(std::ostream& os, const DfgVertex& vtx) {
const uint32_t msb = lsb + selVtxp->width() - 1;
os << toDotId(vtx);
os << " [label=\"SEL\n_[" << msb << ":" << lsb << "]\n";
dumpType(os, vtx.dtypep());
vtx.dtypep()->dumpSmall(os);
os << " / F" << vtx.fanout() << '"';
if (vtx.hasMultipleSinks()) {
os << ", shape=doublecircle";
@ -349,7 +335,7 @@ static void dumpDotVertex(std::ostream& os, const DfgVertex& vtx) {
if (vtx.is<DfgVertexSplice>()) {
os << toDotId(vtx);
os << " [label=\"" << vtx.typeName() << "\n";
dumpType(os, vtx.dtypep());
vtx.dtypep()->dumpSmall(os);
os << " / F" << vtx.fanout() << '"';
if (vtx.hasMultipleSinks()) {
os << ", shape=doubleoctagon";
@ -362,7 +348,7 @@ static void dumpDotVertex(std::ostream& os, const DfgVertex& vtx) {
os << toDotId(vtx);
os << " [label=\"" << vtx.typeName() << "\n";
dumpType(os, vtx.dtypep());
vtx.dtypep()->dumpSmall(os);
os << " / F" << vtx.fanout() << '"';
if (vtx.hasMultipleSinks()) {
os << ", shape=doublecircle";

8
src/V3DfgVertices.h
View File

@ -230,8 +230,8 @@ class DfgSpliceArray final : public DfgVertexSplice {
friend class DfgVisitor;
struct DriverData final {
FileLine* m_flp;
uint32_t m_index;
FileLine* m_flp; // Location of this driver
uint32_t m_index; // Array index driven by this driver (or low index of range)
DriverData() = delete;
DriverData(FileLine* flp, uint32_t index)
: m_flp{flp}
@ -279,8 +279,8 @@ class DfgSplicePacked final : public DfgVertexSplice {
friend class DfgVisitor;
struct DriverData final {
FileLine* m_flp;
uint32_t m_lsb;
FileLine* m_flp; // Location of this driver
uint32_t m_lsb; // LSB of range driven by this driver
DriverData() = delete;
DriverData(FileLine* flp, uint32_t lsb)
: m_flp{flp}