python/cast_mode: Add tests for min/max of double -> int convertions.

Test min/max values of all implicit PyLong + PyFloat -> C u?l?l convertions.

Also check all off-by-one for throwing errors.

Examples/test-suite/overload_simple.i

@@ -166,10 +166,17 @@ char *fid(double, double) {
 %}
 
 %inline %{
-unsigned long long ull() { return 0ULL; }
+int sizeof_long() { return sizeof(long); }
-unsigned long long ull(unsigned long long ull) { return ull; }
+
-long long ll() { return 0LL; }
+unsigned long as_ul() { return 0UL; }
-long long ll(long long ull) { return ull; }
+unsigned long as_ul(unsigned long ul) { return ul; }
+long as_l() { return 0L; }
+long as_l(long l) { return l; }
+
+unsigned long long as_ull() { return 0ULL; }
+unsigned long long as_ull(unsigned long long ull) { return ull; }
+long long as_ll() { return 0LL; }
+long long as_ll(long long ll) { return ll; }
 %}
 
 %include cmalloc.i

Examples/test-suite/php/overload_simple_runme.php

@@ -1,7 +1,7 @@
 <?php
 require "tests.php";
 
-check::functions(array('foo','blah','fbool','fint','fdouble','num','fid','ull','ll','malloc_void','free_void','int_object'));
+check::functions(array('foo','blah','fbool','fint','fdouble','num','fid','as_ull','as_ll','malloc_void','free_void','int_object'));
 check::classes(array('Foo','Bar','overload_simple','Spam','ClassA'));
 // No new vars
 check::globals(array());

Examples/test-suite/python/python_overload_simple_cast_runme.py

@@ -164,34 +164,129 @@ if s.type != "void *":
     raise RuntimeError("Spam(void *)")
 
 
+# nextafter: ++ and -- operators for float, off by one LSB
+# nextafter was released in Python 3.9
+from sys import hexversion
+if hexversion >= 0x3090000:
+    from math import inf, nextafter
+else:
+    # workaround: try to load nextafter from numpy if available
+    try:
+        from numpy import nextafter
+    except:
+        # else just disable this tests
+        def nextafter(x, y):
+            return None
+
+    # math.inf was added in Python 3.5
+    inf = float('inf')
+
+def exceptMatch(fun, arg, res, msg):
+    if arg is None or res is None:
+        # nextafter is missing, so skipping this test
+        return
+    if fun(arg) != res:
+        raise RuntimeError(msg)
+
+def exceptTypeError(fun, arg, msg):
+    if arg is None:
+        # nextafter is missing, so skipping this test
+        return
+    try:
+        fun(arg)
+        raise RuntimeError(msg)
+    except TypeError:
+        pass
+
+# x86_64: long is 32bit on MSVC but 64bit on *nix
+assert sizeof_long() in [4, 8]
+
+# unsigned long
+ulmax = 2**32 - 1
+ulmin = 0
+ulmaxd = float(2**32 - 1)
+ulmind = 0.0
+if sizeof_long() == 8:
+    ulmax = 2**64 - 1
+    ulmaxd = nextafter(float(2**64), 0.0)
+
+exceptMatch(as_ul, ulmin, ulmin, "as_ul(ulmin)")
+exceptMatch(as_ul, ulmax, ulmax, "as_ul(ulmax)")
+exceptMatch(as_ul, ulmind, ulmind, "as_ul(ulmind)")
+exceptMatch(as_ul, ulmaxd, ulmaxd, "as_ul(ulmaxd)")
+
+exceptTypeError(as_ul, ulmin - 1, "as_ul(ulmin - 1)")
+exceptTypeError(as_ul, ulmax + 1, "as_ul(ulmax + 1)")
+exceptTypeError(as_ul, nextafter(ulmind, -inf), "as_ul(ulmind - LSB)")
+exceptTypeError(as_ul, nextafter(ulmaxd, inf), "as_ul(ulmaxd + LSB)")
+
+# long
+lmax = 2**31 - 1
+lmin = -2**31
+lmaxd = float(2**31 - 1)
+lmind = float(-2**31)
+lmaxd_v = lmaxd # expected value after the cast
+lmind_v = lmind
+if hexversion < 0x30a0000:
+    # PyLong_AsLong(float) truncated the input before 3.10
+    lmaxd = nextafter(float(2**31), 0.0)
+    lmind = nextafter(float(-2**31 - 1), 0.0)
+    lmaxd_v = float(2**31 - 1)
+    lmind_v = float(-2**31)
+if sizeof_long() == 8:
+    lmax = 2**63 - 1
+    lmin = -2**63
+    lmaxd = nextafter(float(2**63), 0.0)
+    lmind = float(-2**63)
+    lmaxd_v = lmaxd
+    lmind_v = lmind
+
+exceptMatch(as_l, lmin, lmin, "as_l(lmin)")
+exceptMatch(as_l, lmax, lmax, "as_l(lmax)")
+exceptMatch(as_l, lmind, lmind_v, "as_l(lmind)")
+exceptMatch(as_l, lmaxd, lmaxd_v, "as_l(lmaxd)")
+
+exceptTypeError(as_l, lmin - 1, "as_l(lmin - 1)")
+exceptTypeError(as_l, lmax + 1, "as_l(lmax + 1)")
+exceptTypeError(as_l, nextafter(lmind, -inf), "as_l(lmind - LSB)")
+exceptTypeError(as_l, nextafter(lmaxd, inf), "as_l(lmaxd + LSB)")
+
 # unsigned long long
-ullmax = 9223372036854775807  # 0xffffffffffffffff
+ullmax = 2**64 - 1
-ullmaxd = 9007199254740992.0
 ullmin = 0
+ullmaxd = float(2**53) # 64 bit double significand
 ullmind = 0.0
-if ull(ullmin) != ullmin:
+if sizeof_long() == 8:
-    raise RuntimeError("ull(ullmin)")
+    ullmaxd = nextafter(float(2**64), 0.0)
-if ull(ullmax) != ullmax:
+
-    raise RuntimeError("ull(ullmax)")
+exceptMatch(as_ull, ullmin, ullmin, "as_ull(ullmin)")
-if ull(ullmind) != ullmind:
+exceptMatch(as_ull, ullmax, ullmax, "as_ull(ullmax)")
-    raise RuntimeError("ull(ullmind)")
+exceptMatch(as_ull, ullmind, ullmind, "as_ull(ullmind)")
-if ull(ullmaxd) != ullmaxd:
+exceptMatch(as_ull, ullmaxd, ullmaxd, "as_ull(ullmaxd)")
-    raise RuntimeError("ull(ullmaxd)")
+
+exceptTypeError(as_ull, ullmin - 1, "as_ull(ullmin - 1)")
+exceptTypeError(as_ull, ullmax + 1, "as_ull(ullmax + 1)")
+exceptTypeError(as_ull, nextafter(ullmind, -inf), "as_ull(ullmind - LSB)")
+exceptTypeError(as_ull, nextafter(ullmaxd, inf), "as_ull(ullmaxd + LSB)")
 
 # long long
-llmax = 9223372036854775807  # 0x7fffffffffffffff
+llmax = 2**63 - 1
-llmin = -9223372036854775808
+llmin = -2**63
-# these are near the largest  floats we can still convert into long long
+llmaxd = float(2**53) # 64 bit double significand
-llmaxd = 9007199254740992.0
+llmind = float(-2**53)
-llmind = -9007199254740992.0
+if sizeof_long() == 8:
-if ll(llmin) != llmin:
+    llmaxd = nextafter(float(2**63), 0.0)
-    raise RuntimeError("ll(llmin)")
+    llmind = float(-2**63)
-if ll(llmax) != llmax:
+
-    raise RuntimeError("ll(llmax)")
+exceptMatch(as_ll, llmin, llmin, "as_ll(llmin)")
-if ll(llmind) != llmind:
+exceptMatch(as_ll, llmax, llmax, "as_ll(llmax)")
-    raise RuntimeError("ll(llmind)")
+exceptMatch(as_ll, llmind, llmind, "as_ll(llmind)")
-if ll(llmaxd) != llmaxd:
+exceptMatch(as_ll, llmaxd, llmaxd, "as_ll(llmaxd)")
-    raise RuntimeError("ll(llmaxd)")
+
+exceptTypeError(as_ll, llmin - 1, "as_ll(llmin - 1)")
+exceptTypeError(as_ll, llmax + 1, "as_ll(llmax + 1)")
+exceptTypeError(as_ll, nextafter(llmind, -inf), "as_ll(llmind - LSB)")
+exceptTypeError(as_ll, nextafter(llmaxd, inf), "as_ll(llmaxd + LSB)")
 
 
 free_void(v)