From a19e7fc29533b285088909b82e403d683f73b740 Mon Sep 17 00:00:00 2001 From: MV Shiva Prasad Date: Mon, 21 Jul 2025 14:00:49 +0530 Subject: [PATCH] added BackendMetricPropagationTest and addressed comments --- cronet/build.gradle | 2 +- .../io/grpc/xds/client/BackendMetricPropagationTest.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cronet/build.gradle b/cronet/build.gradle index 646d28323b..1a327f9f96 100644 --- a/cronet/build.gradle +++ b/cronet/build.gradle @@ -57,7 +57,7 @@ dependencies { task javadocs(type: Javadoc) { source = android.sourceSets.main.java.srcDirs - // classpath += files(android.getBootClasspath()) + classpath += files(android.getBootClasspath()) classpath += files({ android.libraryVariants.collect { variant -> variant.javaCompileProvider.get().classpath diff --git a/xds/src/test/java/io/grpc/xds/client/BackendMetricPropagationTest.java b/xds/src/test/java/io/grpc/xds/client/BackendMetricPropagationTest.java index f13fb44aff..42bc52312e 100644 --- a/xds/src/test/java/io/grpc/xds/client/BackendMetricPropagationTest.java +++ b/xds/src/test/java/io/grpc/xds/client/BackendMetricPropagationTest.java @@ -113,11 +113,11 @@ public class BackendMetricPropagationTest { public void fromMetricSpecs_malformedAndUnknownSpecs_areIgnored() { BackendMetricPropagation config = BackendMetricPropagation.fromMetricSpecs( asList( - "cpu_utilization", // valid + "cpu_utilization", null, // ignored - "disk_utilization", // ignored - "named_metrics.", // ignored, empty key - "named_metrics.valid" // valid + "disk_utilization", + "named_metrics.", // empty key + "named_metrics.valid" )); assertThat(config.propagateCpuUtilization).isTrue();