reduce number of compiler warnings (#1691)

This commit is contained in:
Wolf Vollprecht 2022-05-20 18:06:44 +02:00 committed by GitHub
parent 165735558a
commit c124c4c818
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 10 additions and 5 deletions

View File

@ -80,6 +80,7 @@ namespace mamba
switch (format)
{
case QueryResultFormat::kTREE:
case QueryResultFormat::kPRETTY:
res.tree(std::cout);
break;
case QueryResultFormat::kJSON:
@ -95,6 +96,7 @@ namespace mamba
switch (format)
{
case QueryResultFormat::kTREE:
case QueryResultFormat::kPRETTY:
res.tree(std::cout);
break;
case QueryResultFormat::kJSON:

View File

@ -257,8 +257,9 @@ namespace mamba
* Console *
***********/
struct ConsoleData
class ConsoleData
{
public:
std::mutex m_mutex;
std::unique_ptr<ProgressBarManager> p_progress_bar_manager;

View File

@ -1022,7 +1022,7 @@ namespace mamba
return signum;
});
MainExecutor::instance().take_ownership(std::move(t.extract()));
MainExecutor::instance().take_ownership(t.extract());
{
std::unique_lock<std::mutex> l(m);

View File

@ -423,7 +423,7 @@ namespace mamba
// Enable buffering to prevent VS from chopping up UTF-8 byte sequences
setvbuf(stdout, nullptr, _IOFBF, 1000);
#else
static constexpr char* utf8_locales[] = {
static constexpr const char* utf8_locales[] = {
"C.UTF-8",
"POSIX.UTF-8",
"en_US.UTF-8",

View File

@ -215,6 +215,7 @@ PYBIND11_MODULE(bindings, m)
switch (format)
{
case query::TREE:
case query::PRETTY:
res.tree(res_stream);
break;
case query::JSON:
@ -237,6 +238,7 @@ PYBIND11_MODULE(bindings, m)
switch (format)
{
case query::TREE:
case query::PRETTY:
res.tree(res_stream);
break;
case query::JSON:

View File

@ -92,7 +92,7 @@ add_activate_completion(CLI::App* app, std::vector<std::string>& completer_args,
// Mock functions just for completion
CLI::App* activate_subcom = app->add_subcommand("activate");
CLI::App* deactivate_subcom = app->add_subcommand("deactivate");
app->add_subcommand("deactivate");
activate_subcom->callback(
[app, &completer_args, &completed]()
{
@ -124,7 +124,7 @@ add_ps_completion(CLI::App* app, std::vector<std::string>& completer_args, bool&
{ complete_options(list_subcom, completer_args, completed); });
stop_subcom->callback(
[app, &completer_args, &completed]()
[&completer_args, &completed]()
{
if (completer_args.size() == 1)
{